refactor: establish DOM core folder - #311
Merged
Merged
Conversation
This was referenced Aug 3, 2026
Collaborator
Author
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 4, 2026 17:31
571359f to
1267328
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
2 times, most recently
from
August 5, 2026 12:31
9165efd to
f46175e
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 5, 2026 12:34
f46175e to
5d8269a
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 5, 2026 13:40
5d8269a to
35c26ac
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 5, 2026 13:57
35c26ac to
142d2ca
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 5, 2026 14:00
142d2ca to
683b36d
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 5, 2026 14:30
683b36d to
6feb273
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 5, 2026 14:50
6feb273 to
a0306fe
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 5, 2026 15:08
a0306fe to
0d2d581
Compare
This was referenced Aug 5, 2026
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 13:32
52392bb to
daa0a50
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 13:44
daa0a50 to
a6f9c59
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 13:45
a6f9c59 to
64a5d59
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 13:50
64a5d59 to
cedbde9
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 13:54
cedbde9 to
3676db1
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 13:56
3676db1 to
274b244
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 13:57
274b244 to
20f411d
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 13:58
20f411d to
df7c640
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 13:59
df7c640 to
8bb620b
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 14:00
8bb620b to
7e1a7cf
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 14:00
7e1a7cf to
3485614
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 14:03
3485614 to
c9250c6
Compare
jderochervlk
force-pushed
the
codex/option5-dom-core
branch
from
August 7, 2026 14:04
c9250c6 to
f800a62
Compare
jderochervlk
added a commit
that referenced
this pull request
Aug 7, 2026
Tracking issue: #342 ## Stack context Part 2 of the Option 5 folder-feature stack. - Previous: #311 - Next: a separate DOM platform/node folder layer Review this PR as the incremental diff against #311. ## Summary - rename `src/Event` to the target `src/event` folder - keep the complete folder on the unqualified internal `Event` feature - preserve the `WebAPI.Event` implication of `WebAPI.DOM` plus `Event` - leave all public module names and binding signatures unchanged After #311 moved `EventType` into the DOM foundation, this folder now contains the complete event and abort interface bundle without file exclusions or module slices. ## Temporary state - this PR does not introduce compatibility aliases or partial folder membership; the lowercase Event folder is the intended final ownership - the qualified public-feature selective build remains broader than its final shape while the legacy `src/DOM` entry is still tagged `WebAPI.DOM`; later DOM folder layers remove that temporary collision ## Review focus - final Event folder membership - preservation of the public `WebAPI.Event` dependency and flat module paths - confirming this is a path/configuration-only change ## Verification - `node_modules/.bin/rescript clean` - `node_modules/.bin/rescript build --prod --features DOM,Event` - `npm run build` - `npm test` - `npm run format:check` - `git diff --check`
jderochervlk
added a commit
that referenced
this pull request
Aug 7, 2026
Tracking issue: #342 ## Stack context Part 8 of the Option 5 folder-feature stack. - Previous: #317 - Next: another dependency-clean domain folder Review this PR as the incremental diff against #317. ## Summary - rename `src/CSSFontLoading` to the target `src/css-font-loading` folder - move `BaseCSSFontLoading` out of `core` and into its owning complete folder - change the folder to the unqualified internal `CSSFontLoading` feature - add the supported `WebAPI.CSSFontLoading` feature with its `WebAPI.Event` dependency - preserve the flat `WebAPI.FontFace` and `WebAPI.FontFaceSet` public modules ## Temporary state - this PR removes the temporary `BaseCSSFontLoading` placement documented in #311 - the internal `BaseCSSFontLoading` and `CssFontLoadingTypes` aggregation remains inside the correct folder; any final type colocation is deferred to cleanup - no file exclusions or module slices are introduced ## Review focus - the `WebAPI.CSSFontLoading -> WebAPI.Event + CSSFontLoading` implication - complete folder membership, including the formerly foundational helper - unchanged public module paths and signatures ## Verification - `node_modules/.bin/rescript clean` - `node_modules/.bin/rescript build --prod --features DOM,Event,CSSFontLoading` - `npm run build` - `npm test` - `npm run format:check` - `git diff --check`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 1 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #288. It begins the structural stack after the flat interface/type extraction is complete.
Summary
src/Baseto the targetsrc/corefolderEventType.resintocorebeside the foundational event types inDOM.resDOMfeature include the completecorefolderWebAPI.DOMto imply only theDOMfolder featureEventTypefeature slice and the exclusion required by the Event folderPublic module paths remain
WebAPI.DOMandWebAPI.EventType.Temporary state
BaseFile,BaseFileAndDirectoryEntries,BaseCSSFontLoading, andBaseEncryptedMediaExtensionshelpers remain incorefor now; later File, CSSFontLoading, and Media layers will move or replace them in their owning folderssrc/DOMsource entry is still tagged asWebAPI.DOM; later DOM platform/node, HTML, Window, CSSOM, Geometry, SVG, Animation, Navigator, and Canvas layers will split it into unqualified folder featuresWebAPI.DOMselective build is not yet the final light bundle; the internalDOMfolder feature itself compiles independently in this layerReview focus
EventTypebelongs in the foundational core needed byDOM.EventListenerVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOMnpm run buildnpm testnpm run format:checkgit diff --check