Skip to content

refactor: establish Canvas folder feature - #333

Merged
jderochervlk merged 1 commit into
codex/option5-ui-events-folderfrom
codex/option5-canvas-folder
Aug 7, 2026
Merged

refactor: establish Canvas folder feature#333
jderochervlk merged 1 commit into
codex/option5-ui-events-folderfrom
codex/option5-canvas-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 23 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #332.

Summary

  • rename src/Canvas to the target src/canvas folder
  • switch the folder to the unqualified internal Canvas feature
  • add the supported Canvas public feature with Geometry, HTML, Media, and SVG dependencies
  • preserve all existing flat Canvas module paths and binding signatures

Dependency note

The proposal listed Geometry and HTML. The current Canvas bindings also accept SVGElement image values and HTMLVideoElement media values, so the compiler-proven closure additionally implies WebAPI.SVG and WebAPI.Media.

Temporary state

  • VideoColorSpace remains in the legacy DOM folder; Canvas uses the foundational DOM.videoColorSpace type and does not require that interface module
  • the legacy broad WebAPI.DOM source entry remains until its remaining interfaces have been assigned
  • final feature-graph guardrails and cleanup remain deferred until the stack is complete

Review focus

  • the additional SVG/Media dependencies
  • the lowercase folder/internal feature transition
  • preservation of flat public modules

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTML,Media,SVG,Canvas
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c1e77a24d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch 2 times, most recently from b28c6cf to 9eb1540 Compare August 5, 2026 12:14
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch 3 times, most recently from c28014c to ba04a65 Compare August 5, 2026 13:40
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch 2 times, most recently from 03332a9 to c4b7dec Compare August 5, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from c4b7dec to 3d3c9d3 Compare August 5, 2026 14:30
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from 3d3c9d3 to 673b577 Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch 2 times, most recently from f3d9cd1 to e1055cf Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from e1055cf to bc00a0c Compare August 5, 2026 17:40
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from bc00a0c to 2850f1e Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch 2 times, most recently from 43523df to 40f13d0 Compare August 6, 2026 15:04
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from ae091f8 to 0d6c139 Compare August 7, 2026 13:45
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from 0d6c139 to 5437d62 Compare August 7, 2026 13:45
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from 5437d62 to fd56278 Compare August 7, 2026 13:50
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from fd56278 to f1418c3 Compare August 7, 2026 13:54
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from f1418c3 to 57753d0 Compare August 7, 2026 13:56
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from 57753d0 to 29f8da9 Compare August 7, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from 29f8da9 to c620ea6 Compare August 7, 2026 13:58
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from c620ea6 to b617028 Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from b617028 to e142e3a Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from e142e3a to 6920536 Compare August 7, 2026 14:01
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from 6920536 to 05638bd Compare August 7, 2026 14:03
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from 05638bd to faeb8af Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from faeb8af to 0192fcc Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from 0192fcc to 6e4d806 Compare August 7, 2026 14:07
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-folder branch from 6e4d806 to 134c3d4 Compare August 7, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants