Skip to content

refactor: establish CSSFontLoading folder feature - #318

Merged
jderochervlk merged 1 commit into
mainfrom
codex/option5-css-font-loading-folder
Aug 7, 2026
Merged

refactor: establish CSSFontLoading folder feature#318
jderochervlk merged 1 commit into
mainfrom
codex/option5-css-font-loading-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 8 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #317.

Summary

  • rename src/CSSFontLoading to the target src/css-font-loading folder
  • move BaseCSSFontLoading out of core and into its owning complete folder
  • change the folder to the unqualified internal CSSFontLoading feature
  • add the supported WebAPI.CSSFontLoading feature with its WebAPI.Event dependency
  • preserve the flat WebAPI.FontFace and WebAPI.FontFaceSet public modules

Temporary state

  • this PR removes the temporary BaseCSSFontLoading placement documented in refactor: establish DOM core folder #311
  • the internal BaseCSSFontLoading and CssFontLoadingTypes aggregation remains inside the correct folder; any final type colocation is deferred to cleanup
  • no file exclusions or module slices are introduced

Review focus

  • the WebAPI.CSSFontLoading -> WebAPI.Event + CSSFontLoading implication
  • complete folder membership, including the formerly foundational helper
  • unchanged public module paths and signatures

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,CSSFontLoading
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: d6df25203b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch 2 times, most recently from 93c479b to cbc998e Compare August 5, 2026 12:14
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch 3 times, most recently from ceffe7c to d4373fd Compare August 5, 2026 13:40
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from d4373fd to 5fe4b3c Compare August 5, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch 3 times, most recently from fe56d0e to f2e85d6 Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch 2 times, most recently from 5aa9ce8 to c6013db Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from c6013db to 7e9c37a Compare August 5, 2026 17:39
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from 7e9c37a to 3626b9d Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from 3626b9d to e57477d Compare August 6, 2026 14:58
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch 2 times, most recently from 0103364 to 767572f Compare August 6, 2026 17:19
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from 5bb98ff to 9765e92 Compare August 7, 2026 13:50
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from 9765e92 to e90d618 Compare August 7, 2026 13:54
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from e90d618 to fe7c386 Compare August 7, 2026 13:56
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from fe7c386 to ba3b338 Compare August 7, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from ba3b338 to c4c0bfe Compare August 7, 2026 13:58
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from c4c0bfe to 4d45e0d Compare August 7, 2026 13:59
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from 4d45e0d to 37f542c Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from 37f542c to 256cd7d Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from 256cd7d to 505b4f9 Compare August 7, 2026 14:03
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from 505b4f9 to af31e15 Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch 2 times, most recently from a6eae46 to 0b10996 Compare August 7, 2026 14:07
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from 0b10996 to 7cd4124 Compare August 7, 2026 14:09
@jderochervlk
jderochervlk force-pushed the codex/option5-css-font-loading-folder branch from 7cd4124 to e70193d Compare August 7, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants