Skip to content

refactor: establish Media folder feature - #328

Merged
jderochervlk merged 1 commit into
codex/option5-html-folderfrom
codex/option5-media-folder
Aug 7, 2026
Merged

refactor: establish Media folder feature#328
jderochervlk merged 1 commit into
codex/option5-html-folderfrom
codex/option5-media-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 18 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #327.

Summary

  • add the target src/media folder on the unqualified internal Media feature
  • add the supported WebAPI.Media -> WebAPI.HTML + Media feature
  • consolidate Encrypted Media Extensions, Media Capabilities, Media Capture and Streams, Media Session, Picture-in-Picture, Remote Playback, Web Speech, and WebVTT into the Media folder
  • move the remaining media-specific HTML interfaces from the legacy DOM folder
  • move BaseEncryptedMediaExtensions out of the foundational core
  • preserve existing flat module paths and expose MediaError, VideoPlaybackQuality, and the consolidated media interfaces through WebAPI.Media

Temporary state

  • Navigator remains in the legacy DOM folder and references Media-owned types; its broad cross-domain surface is resolved in the later Navigator integration PR
  • Document remains in the legacy DOM folder even though it contains Picture-in-Picture operations; it moves with the later Window/document integration layer
  • the legacy broad WebAPI.DOM source entry remains until its remaining interfaces have been assigned
  • final feature-graph guardrails and helper cleanup remain deferred until the stack is complete

Review focus

  • membership of the consolidated Media domain
  • the WebAPI.Media dependency closure
  • the boundary between general HTML interfaces and media-specific HTML interfaces
  • newly public flat media interface modules

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTML,Media
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30bae3badc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch 3 times, most recently from 9865f4e to 0f9e518 Compare August 5, 2026 12:31
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 0f9e518 to 55fd076 Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 55fd076 to 36c4952 Compare August 5, 2026 13:40
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 36c4952 to 890f8c6 Compare August 5, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 890f8c6 to 7c72fd8 Compare August 5, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch 2 times, most recently from 589dc61 to 8708e73 Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch 2 times, most recently from e036246 to 5db376b Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 5db376b to 7a83011 Compare August 5, 2026 17:40
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 7a83011 to fc8442b Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from fc8442b to c635888 Compare August 6, 2026 14:58
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 604b16a to 20af8ec Compare August 7, 2026 13:50
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 20af8ec to 0c518c6 Compare August 7, 2026 13:54
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 0c518c6 to e08fc8e Compare August 7, 2026 13:56
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from e08fc8e to c9f8b75 Compare August 7, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from c9f8b75 to 7f2160a Compare August 7, 2026 13:58
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 7f2160a to f9f87e3 Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from f9f87e3 to 435bfe4 Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 435bfe4 to 624e619 Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 624e619 to a9cfa4a Compare August 7, 2026 14:03
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from a9cfa4a to 888213d Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 888213d to ac6e90c Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from ac6e90c to 3749c0a Compare August 7, 2026 14:07
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 3749c0a to 900344b Compare August 7, 2026 14:09
@jderochervlk
jderochervlk force-pushed the codex/option5-media-folder branch from 900344b to 19f127f Compare August 7, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants