refactor: establish Navigator folder feature - #336
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 598c76647c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-navigator-folder
branch
2 times, most recently
from
August 5, 2026 12:14
e7beeae to
d3a7562
Compare
jderochervlk
force-pushed
the
codex/option5-navigator-folder
branch
7 times, most recently
from
August 5, 2026 14:50
c992fd0 to
f420337
Compare
jderochervlk
force-pushed
the
codex/option5-navigator-folder
branch
from
August 5, 2026 15:10
f420337 to
fc80e96
Compare
jderochervlk
force-pushed
the
codex/option5-navigator-folder
branch
from
August 5, 2026 15:45
fc80e96 to
4a4bd2c
Compare
jderochervlk
force-pushed
the
codex/option5-navigator-folder
branch
from
August 5, 2026 17:40
4a4bd2c to
a504ad2
Compare
jderochervlk
force-pushed
the
codex/option5-navigator-folder
branch
from
August 6, 2026 14:52
a504ad2 to
3a0eded
Compare
jderochervlk
force-pushed
the
codex/option5-navigator-folder
branch
from
August 6, 2026 14:58
3a0eded to
10d3664
Compare
jderochervlk
force-pushed
the
codex/option5-navigator-folder
branch
from
August 6, 2026 15:04
10d3664 to
2513a9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 26 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #335.
Summary
src/navigatorfolder on the unqualified internalNavigatorfeatureNavigatorinterface out of the legacy DOM folderDependency note
The provisional Option 5 map listed only DOMPlatform and Device. The current
Navigatorsignatures also expose media capabilities/devices/session, storage, service workers, fetch/file/url payloads, clipboard, credentials, and permissions. The broader compiler-proven closure records that existing surface rather than silently omitting modules required by the public interface.Temporary state
WebAPI.DOMsource entry remains for Window, Document, and the final unassigned interfacesReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTML,Media,URL,Fetch,Storage,Messaging,Workers,Device,Navigatornpm run buildnpm testnpm run format:checkgit diff --check