fix(coverage): run pnpm 9 evidence without --trust-lockfile - #1258
fix(coverage): run pnpm 9 evidence without --trust-lockfile#1258seonghobae wants to merge 4 commits into
Conversation
Corepack now honors repository packageManager pins such as pnpm 9.15.9. That binary rejects --trust-lockfile, so LineageWeave frontend heads never reached tests. Keep the flag only for pnpm major 10+, keep exact-base lock matching, and run declared test scripts without synthesizing a coverage instrumenter the package did not declare.
|
@opencode-agent independent exact-head review requested. This identity cannot self-approve. Head unblocks LineageWeave pnpm 9.15.9 coverage-evidence: omit |
|
Warning Review limit reached
Next review available in: 35 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Record ContextualWisdomLab/.github#1258 (pnpm 9 coverage-evidence) and #1259 (thin LineageWeave hourly caller) in the non-identifying baseline so the merge loop names the org-side unblockers without a repo-local duplicate scheduler.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@opencode-agent @cwl-noema-review current-head review for |
|
Cycle retry (2026-08-23T23:06KST): write probe from seonghobae. Independent exact-head APPROVE still required; author will not self-approve. Do not squash-merge without independent APPROVE plus exact-head required success. Issues LineageWeave#79 and #87 stay open. This PR unblocks pnpm 9 coverage evidence for LineageWeave frontend heads. |
pnpm 10.x still rejects --trust-lockfile; trustLockfile landed in pnpm 11.3. Bare jest test scripts keep the documented --coverage flag so changed-source coverage is not dropped for Jest packages.
|
@opencode-agent @cwl-noema-review current-head review for Addressed exact-head Codex P1 threads:
This identity cannot self-approve. Independent OpenCode / Strix / Noema required. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Parse major and minor from corepack pnpm --version so 11.0-11.2 omit the flag. trustLockfile landed in pnpm 11.3; a major>=11 gate still failed those pins the same way pnpm 9/10 did.
|
@opencode-agent @cwl-noema-review current-head review for Addressed exact-head Devin finding PRRT_kwDOS_C14s6bf-Na:
Info threads that are pre-existing or not regressions on this head are acknowledged, not expanded:
This identity cannot self-approve. Independent OpenCode / Strix / Noema required. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
The PR description on this head already matches the 11.3 gate: --trust-lockfile only when major > 11 or (major == 11 and minor >= 3). pnpm 9, 10, and 11.0–11.2 omit the flag. CHANGELOG, doctoring, and test_opencode_coverage_gates_trust_lockfile_on_pnpm_11_3 agree. No code change.
|
@opencode-agent @cwl-noema-review current-head review for Remaining Devin info thread on the PR description is resolved: the description already matches the 11.3 gate. Independent OpenCode / Strix / Noema required. This identity cannot self-approve. |
Record auto-merge on ContextualWisdomLab/.github#1258/#1259 and LineageWeave#494, the current #426 head, and that #497 is already stacked here. Do not fold this file back into #494.
|
@opencode-agent @cwl-noema-review current-head review for Strix fail on this head was provider infrastructure (LLM connection / missing artifact), not a finding in the pnpm 11.3 gate. Independent OpenCode / Strix / Noema required. This identity cannot self-approve. |
* fix: restore login typecheck and non-identifying gap baseline Unauthenticated login no longer mounts Admin settings with an undefined token, so tsc -b succeeds on protected main. Login persists a validated OIDC return URL through the existing helpers. The gap baseline is rewritten without identifying record identifiers and bound to the current PR and issue inventory. * docs: bind gap baseline to org coverage and hourly caller PRs Record ContextualWisdomLab/.github#1258 (pnpm 9 coverage-evidence) and #1259 (thin LineageWeave hourly caller) in the non-identifying baseline so the merge loop names the org-side unblockers without a repo-local duplicate scheduler. * Revert "docs: bind gap baseline to org coverage and hourly caller PRs" This reverts commit a4b604b. * fix: keep login gate repair minimal * test: skip optional-extra suites when the sandbox lacks them (#503) OpenCode coverage-evidence cannot install LineageWeave backend extras. Collection now ignores files that import asyncpg, psycopg2, redis, or fast_mlsirm when those modules are absent. Hosted CI still installs the extras, so the full suite continues to run there. * fix: apply optional-extra skips repository-wide * fix: keep optional collection work unique * fix: parse optional imports exactly * fix: preserve pytest ignore semantics * test: cover optional collection hook edges * fix: restore login typecheck without unauthenticated AdminPanel Main fails tsc because login imported unused OIDC helpers and mounted AdminPanel with an undefined access token. Keep the optional-extra collection work unique; do not fold the ADR 0001 gap baseline into this head. * Revert "fix: restore login typecheck without unauthenticated AdminPanel" This reverts commit 327c359. * test: cover optional collection edges * fix: avoid skipping lazy redis imports * fix: tolerate non-UTF-8 collection paths * fix: restore login typecheck without unauthenticated AdminPanel Protected main fails tsc because login imported unused OIDC helpers and mounted AdminPanel with an undefined access token. Keep optional- extra collection unique. Do not fold the ADR 0001 gap baseline into this head. * Revert "fix: restore login typecheck without unauthenticated AdminPanel" This reverts commit b195b42.
|
@opencode-agent @cwl-noema-review current-head review for All review threads resolved. pnpm 11.3+ gate for |
1 similar comment
|
@opencode-agent @cwl-noema-review current-head review for All review threads resolved. pnpm 11.3+ gate for |
|
Exact-head ping for independent OpenCode/Strix/Noema review on |
|
@opencode-agent @cwl-noema-review exact-head independent review for pnpm |
|
@opencode-agent @cwl-noema-review exact-head independent review for All review threads resolved. |
|
Exact-head independent review required on
|
|
@opencode-agent @cwl-noema-review exact-head independent review for All review threads resolved. |
|
@opencode-agent @cwl-noema-review exact-head independent review for live head
|
|
@opencode-agent @cwl-noema-review exact-head independent review for
|
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.
Findings
1. HIGH Current-head GitHub Checks - Fix failed required checks before approval
- Problem: Failed same-head checks remain for
897819c48279b0c0d5e2372eb39dce6120784685. - Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
- Fix: Read and fix the failed check logs below, then rerun the current-head checks.
- Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.
Failed checks:
- Strix Security Scan/strix: FAILURE (https://github.com/ContextualWisdomLab/.github/actions/runs/32654726819/job/97231595848)
- Strix Security Scan/strix: failure (https://github.com/ContextualWisdomLab/.github/actions/runs/32654726819/job/97231595848)
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: opencode-review-dispatch.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: opencode-review-dispatch.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file: CHANGELOG.md"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file: CHANGELOG.md"]
R2 --> V2["required checks"]
Evidence --> S3["Docs: opencode-pnpm-lock-compat.md"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs: opencode-pnpm-lock-compat.md"]
R3 --> V3["docs review"]
Evidence --> S4["CI script: test_strix_quick_gate.sh"]
S4 --> I4["review and security gate shell path"]
I4 --> R4["Review risk: CI script: test_strix_quick_gate.sh"]
R4 --> V4["bash -n plus Strix self-test"]
Evidence --> S5["Test (2 files)"]
S5 --> I5["regression suite"]
I5 --> R5["Review risk: Test (2 files)"]
R5 --> V5["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed. Findings1. HIGH Current-head GitHub Checks - Fix failed required checks before approval
Failed checks:
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: opencode-review-dispatch.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: opencode-review-dispatch.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file: CHANGELOG.md"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file: CHANGELOG.md"]
R2 --> V2["required checks"]
Evidence --> S3["Docs: opencode-pnpm-lock-compat.md"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs: opencode-pnpm-lock-compat.md"]
R3 --> V3["docs review"]
Evidence --> S4["CI script: test_strix_quick_gate.sh"]
S4 --> I4["review and security gate shell path"]
I4 --> R4["Review risk: CI script: test_strix_quick_gate.sh"]
R4 --> V4["bash -n plus Strix self-test"]
Evidence --> S5["Test (2 files)"]
S5 --> I5["regression suite"]
I5 --> R5["Review risk: Test (2 files)"]
R5 --> V5["targeted test run"]
|
There was a problem hiding this comment.
Pull request overview
OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.
Findings
1. HIGH Current-head GitHub Checks - Fix failed required checks before approval
- Problem: Failed same-head checks remain for
897819c48279b0c0d5e2372eb39dce6120784685. - Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
- Fix: Read and fix the failed check logs below, then rerun the current-head checks.
- Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.
Failed checks:
- Strix Security Scan/strix: FAILURE (https://github.com/ContextualWisdomLab/.github/actions/runs/32654726819/job/97231595848)
- Strix Security Scan/strix: failure (https://github.com/ContextualWisdomLab/.github/actions/runs/32654726819/job/97231595848)
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: opencode-review-dispatch.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: opencode-review-dispatch.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file: CHANGELOG.md"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file: CHANGELOG.md"]
R2 --> V2["required checks"]
Evidence --> S3["Docs: opencode-pnpm-lock-compat.md"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs: opencode-pnpm-lock-compat.md"]
R3 --> V3["docs review"]
Evidence --> S4["CI script: test_strix_quick_gate.sh"]
S4 --> I4["review and security gate shell path"]
I4 --> R4["Review risk: CI script: test_strix_quick_gate.sh"]
R4 --> V4["bash -n plus Strix self-test"]
Evidence --> S5["Test (2 files)"]
S5 --> I5["regression suite"]
I5 --> R5["Review risk: Test (2 files)"]
R5 --> V5["targeted test run"]
1 participant
Product result
OpenCode coverage evidence now reaches JavaScript tests on trusted-base pnpm 9, 10, and 11.0–11.2 pins instead of failing on the pnpm 11.3-only
--trust-lockfileoption. Missing instrumentation remains an actionable failed coverage result; plain passing tests are never represented as 100% frontend coverage.Root cause
Corepack correctly activates each repository
packageManagerpin, but the install path unconditionally passed a pnpm 11.3-only flag. The coverage path also appended--coveragewithout proving the selected runner could consume it, while a later revision incorrectly marked uninstrumented tests as coverage PASS.Exact-head behavior
--trust-lockfileonly for pnpm 11.3 and newer; retain exact base/head lock identity,--offline,--frozen-lockfile,--ignore-scripts, and the trusted writable store clone on every version.--coverageonly for bare Jest or Vitest with lock-pinned@vitest/coverage-v8/@vitest/coverage-istanbul. A merely installedc8,nyc, Istanbul, or Vitest provider never authorizes an unrelated runner flag.uv sync --project.Verification
test_strix_quick_gate: PASS; required smoke, actionlint, Bash syntax, compileall, diff check, and production docstrings 100% pass.Independent exact-head approval and terminal protected checks remain required. No self-approval, force push, admin bypass, or merge-policy weakening.