test: preserve optional-extra pytest collection - #494
Conversation
Unauthenticated login no longer mounts Admin settings with an undefined token, so tsc -b succeeds on protected main. Login persists a validated OIDC return URL through the existing helpers. The gap baseline is rewritten without identifying record identifiers and bound to the current PR and issue inventory.
seonghobae
left a comment
There was a problem hiding this comment.
Verification comment only — not an approval (this identity cannot self-approve).
Exact head 077ec72:
- Unauthenticated login no longer mounts Admin settings with an undefined token.
- Login uses
returnUrlFromLocation+rememberOidcReturnUrl. - Local
tsc -bpassed; App + OIDC tests: 83 passed. - Gap baseline is non-identifying and bound to the live PR/issue inventory.
Independent OpenCode / Strix / Noema exact-head review is still required before squash-merge.
|
Independent exact-head review requested (OpenCode / Strix / Noema). This identity cannot self-approve. Local verification on
Please review this exact head. Squash-merge only after independent approval and current checks. |
📝 WalkthroughWalkthrough선택적 백엔드 모듈이 설치되지 않은 환경에서 관련 테스트 수집을 건너뛰도록 했습니다. AST 기반 import 감지 헬퍼와 pytest 수집 훅을 추가하고, 직접·전이 import 및 예외 경로를 테스트했습니다. Changes선택적 추가 기능 수집 제어
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🟡 Moderate · up to The added optional collection path can fail test collection with a missing numpy dependency mapping in a supported environment. This bounded integration issue should be fixed or explicitly accepted before merge. Sequence Diagram(s)sequenceDiagram
participant Pytest
participant conftest.py
participant optional_extra_collection
participant TestPath
Pytest->>conftest.py: pytest_ignore_collect 호출
conftest.py->>optional_extra_collection: 누락 모듈 및 경로 의존성 조회
optional_extra_collection->>TestPath: Python 파일 import 분석
optional_extra_collection-->>conftest.py: 수집 제외 여부 반환
conftest.py-->>Pytest: 경로 수집 또는 건너뛰기
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@opencode-agent independent exact-head review requested. This identity cannot self-approve. Head
Please review this exact head. Squash-merge only after independent approval (OpenCode + one other independent reviewer) and current checks. |
Record ContextualWisdomLab/.github#1258 (pnpm 9 coverage-evidence) and #1259 (thin LineageWeave hourly caller) in the non-identifying baseline so the merge loop names the org-side unblockers without a repo-local duplicate scheduler.
|
@opencode-agent independent exact-head review requested after the gap-baseline bind to ContextualWisdomLab/.github#1258 and #1259. This identity cannot self-approve. Still the login |
|
Closing as superseded after an exact-head comparison, rather than creating a third competing baseline writer.
No review was dismissed or self-approved, and no protected merge was attempted. |
Pull request was closed
|
Reopened this cycle: login #426 remains the ontology Pages carrier. This head stays the smallest shared-gate login/ |
|
@opencode-agent current-head review for |
|
@opencode-agent @cwl-noema-review current-head review for Login-only unique value: |
Record auto-merge on ContextualWisdomLab/.github#1258/#1259 and LineageWeave#494, the current #426 head, and that #497 is already stacked here. Do not fold this file back into #494.
|
@opencode-agent @cwl-noema-review current-head review for |
OpenCode coverage-evidence cannot install LineageWeave backend extras. Collection now ignores files that import asyncpg, psycopg2, redis, or fast_mlsirm when those modules are absent. Hosted CI still installs the extras, so the full suite continues to run there.
Main fails tsc because login imported unused OIDC helpers and mounted AdminPanel with an undefined access token. Keep the optional-extra collection work unique; do not fold the ADR 0001 gap baseline into this head.
|
@opencode-agent @cwl-noema-review current-head review for Restored the login |
…heads Record ContextualWisdomLab/.github#1245 (installation rate-limit retry) and the current LineageWeave#494 login tsc plus optional-extra skip. Do not fold this file into #494.
Protected main fails tsc because login imported unused OIDC helpers and mounted AdminPanel with an undefined access token. Keep optional- extra collection unique. Do not fold the ADR 0001 gap baseline into this head.
|
@opencode-agent @cwl-noema-review current-head review for Restored login |
This reverts commit b195b42.
|
@opencode-agent @cwl-noema-review current-head review for |
Record LineageWeave#494 `b195b42` (login tsc plus optional-extra skip). Do not fold this file into #494.
…k' into codex/pr494-optional-hook
1ff0cd1
into
worktree-fix-frontend-build-break
Product result
OpenCode coverage evidence can collect the runnable LineageWeave suite in a networkless environment that lacks optional backend extras. Hosted CI still installs the extras and collects the complete suite.
Exact stacked scope
5d9728a16051e7db453ca513cd5baa75be7450cc2cf16db25d25ef90bf43737917a911ed8b840794(worktree-fix-frontend-build-break)The parent is now composed into the head by a normal merge. This fixes the prior synthetic-merge TypeScript failure while keeping the effective #494 diff exactly four optional-collection files: the root pytest hook, its standard-library AST helper, focused synthetic tests, and the changelog fragment. #426 owns the shared App/OIDC/Admin repair, ontology publication, and ADR 0001 gap baseline.
What this head changes
testsandbackend/tests.lineageweave.period_reportconsumers but notpost_evaluationconsumers.None, preserving pytest built-in and project ignore rules.Validation
--ignorecollection omitted the requested helper suite.Protected stack lifecycle
#426 must reach protected
mainfirst. Then retarget #494 tomainand obtain fresh exact-head checks, threads, and independent approvals; no evidence from this unprotected stack base transfers. Auto-merge remains disabled while stacked. No self-approval, admin bypass, force push, provider credential, real record, or PII is included.