Skip to content

refactor: remove DOM compatibility types - #310

Open
jderochervlk wants to merge 4 commits into
codex/svg-interfacesfrom
codex/dom-types-cleanup
Open

refactor: remove DOM compatibility types#310
jderochervlk wants to merge 4 commits into
codex/svg-interfacesfrom
codex/dom-types-cleanup

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Summary

  • replace the temporary DOMTree aliases from refactor: introduce DOMTree compatibility foundation #301 with the concrete recursive interface family
  • move the remaining shared non-tree types into DOM
  • update residual DOM, Canvas, observer, UI event, WebAudio, and test consumers
  • delete DomTypes and MutationObserverTypes

Temporary state

Review focus

  • correctness of the concrete recursive DOM type graph
  • residual consumer migrations and the absence of deleted compatibility references
  • whether the large change remains behavior-neutral despite needing to land atomically

Verification

  • npm run build
  • npm test
  • npm run format:check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13fac32b58

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/unmonorepo/rewrite-references.test.mjs Outdated
Comment thread src/DOM/DOMTree.res Outdated
@jderochervlk
jderochervlk force-pushed the codex/dom-types-cleanup branch from 13fac32 to c127bf9 Compare August 4, 2026 17:31
@jderochervlk
jderochervlk force-pushed the codex/dom-types-cleanup branch from c127bf9 to 34e7c62 Compare August 5, 2026 12:14
@jderochervlk
jderochervlk force-pushed the codex/dom-types-cleanup branch 2 times, most recently from 3701309 to f0b6bbf Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/dom-types-cleanup branch 2 times, most recently from 713f8c2 to eefdc53 Compare August 5, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/dom-types-cleanup branch from eefdc53 to 242510e Compare August 5, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/dom-types-cleanup branch from 242510e to 43598ee Compare August 5, 2026 14:30
@jderochervlk
jderochervlk force-pushed the codex/dom-types-cleanup branch from 81fd415 to a75a304 Compare August 5, 2026 15:08
@jderochervlk
jderochervlk force-pushed the codex/dom-types-cleanup branch 2 times, most recently from c6c6523 to 6ec0fca Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/dom-types-cleanup branch from 6ec0fca to 431cc49 Compare August 6, 2026 14:58
@jderochervlk
jderochervlk force-pushed the codex/dom-types-cleanup branch from 431cc49 to cebaa00 Compare August 6, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant