Skip to content

refactor: migrate core DOM tree interfaces - #302

Open
jderochervlk wants to merge 1 commit into
codex/dom-tree-foundationfrom
codex/dom-tree-interfaces
Open

refactor: migrate core DOM tree interfaces#302
jderochervlk wants to merge 1 commit into
codex/dom-tree-foundationfrom
codex/dom-tree-interfaces

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Summary

  • migrate core node, element, range, traversal, selection, and character-data APIs onto DOMTree
  • add focused interface modules including Attr, AbstractRange, StaticRange, CDATASection, and ProcessingInstruction
  • move interface-specific operations out of the broad type modules

Temporary state

Review focus

  • recursive type relationships and public method signatures
  • completeness of each newly owning interface module
  • absence of behavioral changes beyond type ownership

Verification

  • npm run build
  • npm test
  • npm run format:check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08f7c6a1ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/DOM/Selection.res
Comment thread src/DOM/HTMLSlotElement.res
@jderochervlk
jderochervlk force-pushed the codex/dom-tree-interfaces branch from 08f7c6a to 5a859e2 Compare August 4, 2026 17:31
@jderochervlk
jderochervlk force-pushed the codex/dom-tree-interfaces branch from 5a859e2 to b327f5d Compare August 5, 2026 12:14
@jderochervlk
jderochervlk force-pushed the codex/dom-tree-interfaces branch from b327f5d to 0268243 Compare August 5, 2026 12:31
@jderochervlk
jderochervlk force-pushed the codex/dom-tree-interfaces branch 2 times, most recently from d7bb287 to 4f100d7 Compare August 5, 2026 13:40
@jderochervlk
jderochervlk force-pushed the codex/dom-tree-interfaces branch from 4f100d7 to 62c8673 Compare August 5, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/dom-tree-interfaces branch from 62c8673 to 0c3bb67 Compare August 5, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/dom-tree-interfaces branch from 0c3bb67 to ea6fb05 Compare August 5, 2026 15:08
@jderochervlk
jderochervlk force-pushed the codex/dom-tree-interfaces branch 2 times, most recently from 9727a53 to f8a846b Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/dom-tree-interfaces branch from f8a846b to 02905ae Compare August 6, 2026 14:58
@jderochervlk
jderochervlk force-pushed the codex/dom-tree-interfaces branch from 02905ae to 87a2c53 Compare August 6, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant