refactor: extract Document, Animation, and XPath interfaces - #287
refactor: extract Document, Animation, and XPath interfaces#287jderochervlk wants to merge 6 commits into
Conversation
5ff56df to
84d24ac
Compare
brnrdog
left a comment
There was a problem hiding this comment.
I liked the types living within their interfaces, makes them much more discoverable than before with the DOMTypes. I think the DOMTree is fair given the recursive types.
I'm just missing a .t for Element/Node/HTMLElement, like we do for other modules. What if we add a small alias on each like:
type t = DOMTree.element
include Impl({type t = t})
Yeah, I think having a type |
fa09c7b to
2e9ab9f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e9ab9f34c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9d52633 to
4de88f7
Compare
d27cf2a to
4a89510
Compare
59a2d1e to
7ab44b8
Compare
7283c5e to
b7ad5ca
Compare
b7ad5ca to
17bf86f
Compare
17bf86f to
aad6452
Compare
Tracking issue: #342
Summary
Documentmethods and supporting option records into the owningDocumentmoduleAnimation.t, animation state types, and animation methods locallyDomTypesTemporary state
DomTypesstill contains the unrelated recursive DOM, HTML, SVG, CSS, and helper types needed by later layersDomTypesReview focus
DomTypesaliasesVerification
npm run buildnpm testnpm run format:check