Skip to content

docs: mark the gap-baseline DAG-view entry resolved - #440

Closed
seonghobae wants to merge 2 commits into
mainfrom
worktree-fix-gap-baseline-dag-stale
Closed

docs: mark the gap-baseline DAG-view entry resolved#440
seonghobae wants to merge 2 commits into
mainfrom
worktree-fix-gap-baseline-dag-stale

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • docs/product-technical-gap-baseline.md item 9 claimed "DAG (Directed Acyclic Graph) view is currently missing from the frontend" for a specific post.
  • That's stale: frontend/src/LineageDag.tsx has existed since feat: show the reconstruct DAG as a git-branch SVG #14 (long-merged, predates this session) and is wired into every post's Event Lineage section (EventLineageSection in App.tsx), rendering the git-branch-style graph whenever the post has scoped lineage nodes. Confirmed via git log on LineageDag.tsx and reading the render path directly.
  • Marked the entry (Resolved) matching the doc's existing convention for other closed items, and noted that if the specific named post still shows no graph, that's a data-reconstruction gap (no lineage edges for that post), not a UI gap — so it doesn't silently disappear if actually reproduced.
  • Docs-only change, no code touched.

Test plan

  • N/A — documentation correction only, no executable code changed.

🤖 Generated with Claude Code


Open in Devin Review

frontend/src/LineageDag.tsx has existed since #14 and is wired into
every post's Event Lineage section (App.tsx's EventLineageSection),
so the baseline's claim that a DAG view is missing from the frontend
is stale. If the named post still shows no graph, that's a data
(missing reconstructed lineage) gap, not a UI gap -- noted as the
follow-up path instead of leaving a misleading "missing UI" entry
that could send future work toward rebuilding something that already
exists.
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7068d2cf-8540-4c85-8b7f-a52e613df5d8

📥 Commits

Reviewing files that changed from the base of the PR and between ef6f5a5 and 612f206.

📒 Files selected for processing (3)
  • docs/product-technical-gap-baseline.md
  • frontend/src/App.test.tsx
  • frontend/src/App.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Same shared-ancestor bug as #418/#415/#426/#427/#429/#431/#434/#435/#436/#437/#438/#439:
the login button built an unsanitized returnUrl inline instead of
returnUrlFromLocation()/rememberOidcReturnUrl(), and removed the
unreachable login-screen AdminPanel render.
@seonghobae
seonghobae enabled auto-merge (squash) August 22, 2026 13:25

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

Comment thread frontend/src/App.tsx
@seonghobae

Copy link
Copy Markdown
Contributor Author

Closing unmerged as replaced by protected-main PR #516 at exact head 6af3dc78967177948d9045c47a252b41f654f194. The replacement preserves the source-backed DAG-status correction, removes all private-runtime post and organization identifiers from the gap baseline, adds a permanent non-identifying documentation contract, and carries none of this branch’s duplicate OIDC/App changes. Exact replacement evidence: 754 passed/17 skipped; changed test 66 statements + 8 branches at 100%; docstrings 100%. No reviews or checks transfer.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded by #516; closed without merge and branch retained.

@seonghobae seonghobae closed this Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant