Skip to content

docs: keep buyer-gap evidence non-identifying - #516

Merged
seonghobae merged 4 commits into
worktree-fix-frontend-build-breakfrom
codex/gap-baseline-private-id-sanitization-20260824
Aug 23, 2026
Merged

docs: keep buyer-gap evidence non-identifying#516
seonghobae merged 4 commits into
worktree-fix-frontend-build-breakfrom
codex/gap-baseline-private-id-sanitization-20260824

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Outcome

  • removes private-runtime post and organization identifiers from the product-gap baseline;
  • restates unresolved gaps as synthetic-fixture acceptance contracts;
  • records the already-shipped EventLineageSectionLineageDag surface as resolved;
  • adds a permanent documentation-hygiene regression forbidding post= identifiers in the baseline.

Exact validation

  • uv run --extra dev pytest -q tests/test_documentation_hygiene.py: 5 passed
  • uv run --extra dev --extra backend coverage run --branch -m pytest -q: 754 passed, 17 skipped
  • changed test module: 66 statements + 8 branches, 100%
  • changed test module docstrings: 100%
  • git diff --check; CodeGraph synchronized

This is the protected-main replacement for stale PR #440. It carries none of #440’s duplicated OIDC/App changes and transfers no reviews or checks.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4cbce6f6-3a14-4231-8576-7e90f0a9292e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent Please review exact head 6af3dc78967177948d9045c47a252b41f654f194. This is the protected-main replacement for #440: private-runtime identifiers are removed, unresolved gaps are synthetic acceptance contracts, the existing post-scoped DAG is recorded accurately, and the duplicate OIDC/App diff is absent. Local exact: 754 passed/17 skipped; changed test 66 statements + 8 branches at 100%; docstrings 100%.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor Author

@opencode-agent @cwl-noema-review exact-head independent review for aeb9af4e717cce0877acf6fe26d492ee60d80c7f.

Protected-main non-identifying gap baseline (ADR 0001). Replaces stale #440. Synthetic-fixture acceptance only; forbids post= identifiers. Auto-merge remains available once independent APPROVE lands. This identity cannot self-approve. Checks are not blockers.

…ng-guard

# Conflicts:
#	CHANGELOG.md
#	docs/product-technical-gap-baseline.md
@seonghobae
seonghobae changed the base branch from main to worktree-fix-frontend-build-break August 23, 2026 18:53
@seonghobae

Copy link
Copy Markdown
Contributor Author

Composed current #426 (04fe942901ae) without force-push and retargeted this hygiene guard to that non-main parent. Conflict resolution keeps #426’s already non-identifying evidence baseline and adds only the changelog receipt plus the UUID / post= / post: / identifier-shaped post scanner contract. Exact composed head 006db55368a1: uv run pytest tests/test_documentation_hygiene.py -q -> 5 passed; git diff --check clean.

@seonghobae
seonghobae merged commit a7891d1 into worktree-fix-frontend-build-break Aug 23, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in naruon Platform Roadmap Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant