feat(tables): support plain predicates in v2 queries - #6292
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Contracts: Runtime: Docs: Block descriptions, filter placeholders, wand prompts, and generated Copilot tool metadata now describe plain predicates and Reviewed by Cursor Bugbot for commit 1516f07. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR adds support for plain
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported recursion path now performs an iterative complexity check before every recursive predicate validation or parsing entry point.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/table/query-builder/predicate.ts | Adds canonical plain-predicate normalization and an iterative complexity precheck that prevents deeply nested input from reaching recursive validation. |
| apps/sim/lib/table/query-builder/validate.ts | Extends runtime validation to plain predicates and invokes the shared complexity guard before recursive structural checks. |
| apps/sim/lib/api/contracts/tables.ts | Adds guarded plain-predicate contract parsing and canonical normalization while retaining group-only parsing at dual-grammar legacy boundaries. |
| apps/sim/blocks/blocks/table_v2.ts | Validates and normalizes plain predicate input before table block execution. |
| apps/sim/tools/table/query_rows_v2.ts | Routes v2 tool predicates through guarded validation and normalization before querying. |
| apps/sim/lib/copilot/tools/server/table/user-table.ts | Validates and normalizes plain predicates for Copilot query, update, and delete operations. |
Reviews (3): Last reviewed commit: "fix(tables): bound predicate validation" | Re-trigger Greptile
a5e6fa8 to
ca7c8d1
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ca7c8d1. Configure here.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1516f07. Configure here.
Summary
{ field, op, value }predicate across v2 table APIs, blocks, tools, saved views, and CopilotType of Change
Testing
bun run type-checkChecklist