Skip to content

refactor: complete Device interface ownership - #338

Open
jderochervlk wants to merge 1 commit into
codex/option5-canvas-valuesfrom
codex/option5-device-screen-orientation
Open

refactor: complete Device interface ownership#338
jderochervlk wants to merge 1 commit into
codex/option5-canvas-valuesfrom
codex/option5-device-screen-orientation

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 28 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #337.

Summary

  • move ScreenOrientation from the legacy DOM folder into src/device
  • expose the existing flat module through WebAPI.Device
  • leave the Device feature dependency closure unchanged

Why this follows the Device PR

The initial Device consolidation focused on the existing capability folders. ScreenOrientation was still published from the broad DOM folder even though it is an event-capable device/display interface. This one-file follow-up makes its ownership explicit before the Window layer removes the legacy folder.

Temporary state

  • only Window/browser-entry interfaces remain in the legacy DOM folder
  • the legacy broad WebAPI.DOM source entry is removed by the immediately following Window PR
  • final feature-graph guardrails and helper cleanup remain deferred until the stack is complete

Review focus

  • ScreenOrientation ownership
  • unchanged flat public module path and Device closure

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,Device
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 91a3291697

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch from 91a3291 to 5899e7f Compare August 4, 2026 17:31
@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch 2 times, most recently from 32d3593 to ac01b46 Compare August 5, 2026 12:31
@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch from ac01b46 to 1ae6884 Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch from 1ae6884 to ce97d79 Compare August 5, 2026 13:40
@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch 2 times, most recently from 73ff0b4 to d4ace5a Compare August 5, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch 2 times, most recently from 95398e1 to e02c8cb Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch 2 times, most recently from 2e83475 to 740ee9d Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch from 740ee9d to a749894 Compare August 5, 2026 17:40
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch from a749894 to e489625 Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch from e489625 to 2da3c87 Compare August 6, 2026 14:58
@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch 3 times, most recently from 74b9d08 to e123e79 Compare August 6, 2026 20:04
@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch from e123e79 to 37bc568 Compare August 6, 2026 20:09
@jderochervlk
jderochervlk force-pushed the codex/option5-device-screen-orientation branch from 37bc568 to 7e1b5db Compare August 6, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant