Skip to content

refactor: establish HTML folder feature - #327

Open
jderochervlk wants to merge 1 commit into
codex/option5-dom-nodes-folderfrom
codex/option5-html-folder
Open

refactor: establish HTML folder feature#327
jderochervlk wants to merge 1 commit into
codex/option5-dom-nodes-folderfrom
codex/option5-html-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 17 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #326.

Summary

  • add the target src/html folder on the unqualified internal HTML feature
  • move 61 non-media HTML interface modules out of the legacy broad DOM folder
  • add the supported WebAPI.HTML -> WebAPI.DOMNodes + WebAPI.File + HTML feature
  • expose the existing HTMLUnknownElement interface publicly
  • preserve every existing flat HTML module path and binding signature

Media boundary

DomHTMLMediaElement, HTMLAudioElement, HTMLTrackElement, and HTMLVideoElement remain for the next Media layer. Their APIs directly reference Remote Playback, Picture-in-Picture, WebVTT, media-error, time-range, and playback-quality types. Moving them here would create an HTML <-> Media cycle because Media already depends on HTML.

Temporary state

  • the four media-specific HTML interfaces remain in the legacy folder for one layer and move with Media next
  • HTML.res is received transitively from DOMNodes because Element and ShadowRoot require its serialization/shadow-root options
  • final helper-type cleanup remains deferred

Review focus

  • HTML folder membership and the explicit media boundary
  • the WebAPI.HTML dependency closure
  • public exposure of HTMLUnknownElement

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTML
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9604786121

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch from 9604786 to b9e476c Compare August 4, 2026 17:31
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch from b9e476c to 2674086 Compare August 5, 2026 12:14
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch 2 times, most recently from 078fc7c to 710a58f Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch 2 times, most recently from df6ed82 to fe9ef21 Compare August 5, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch 2 times, most recently from bf43e39 to 90c3213 Compare August 5, 2026 14:30
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch from 90c3213 to 012a2e6 Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch from 012a2e6 to a85a213 Compare August 5, 2026 15:09
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch from a85a213 to 0a9debe Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch from 0a9debe to dbdf274 Compare August 5, 2026 17:40
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch from dbdf274 to 894fe0a Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch from 894fe0a to 01b461c Compare August 6, 2026 14:58
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch 2 times, most recently from d9d9ff0 to 5c43bb2 Compare August 6, 2026 17:19
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch from 5c43bb2 to ddaf740 Compare August 6, 2026 20:04
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch 2 times, most recently from 095c8d2 to 5b4a500 Compare August 6, 2026 20:50
@jderochervlk
jderochervlk force-pushed the codex/option5-html-folder branch from 5b4a500 to 1d69c8e Compare August 6, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant