refactor: establish HTML folder feature - #327
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9604786121
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
from
August 4, 2026 17:31
9604786 to
b9e476c
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
from
August 5, 2026 12:14
b9e476c to
2674086
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
2 times, most recently
from
August 5, 2026 12:34
078fc7c to
710a58f
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
2 times, most recently
from
August 5, 2026 13:57
df6ed82 to
fe9ef21
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
2 times, most recently
from
August 5, 2026 14:30
bf43e39 to
90c3213
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
from
August 5, 2026 14:50
90c3213 to
012a2e6
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
from
August 5, 2026 15:09
012a2e6 to
a85a213
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
from
August 5, 2026 15:45
a85a213 to
0a9debe
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
from
August 5, 2026 17:40
0a9debe to
dbdf274
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
from
August 6, 2026 14:52
dbdf274 to
894fe0a
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
from
August 6, 2026 14:58
894fe0a to
01b461c
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
2 times, most recently
from
August 6, 2026 17:19
d9d9ff0 to
5c43bb2
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
from
August 6, 2026 20:04
5c43bb2 to
ddaf740
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
2 times, most recently
from
August 6, 2026 20:50
095c8d2 to
5b4a500
Compare
jderochervlk
force-pushed
the
codex/option5-html-folder
branch
from
August 6, 2026 20:58
5b4a500 to
1d69c8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 17 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #326.
Summary
src/htmlfolder on the unqualified internalHTMLfeatureWebAPI.HTML -> WebAPI.DOMNodes + WebAPI.File + HTMLfeatureHTMLUnknownElementinterface publiclyMedia boundary
DomHTMLMediaElement,HTMLAudioElement,HTMLTrackElement, andHTMLVideoElementremain for the next Media layer. Their APIs directly reference Remote Playback, Picture-in-Picture, WebVTT, media-error, time-range, and playback-quality types. Moving them here would create anHTML <-> Mediacycle because Media already depends on HTML.Temporary state
HTML.resis received transitively from DOMNodes because Element and ShadowRoot require its serialization/shadow-root optionsReview focus
WebAPI.HTMLdependency closureHTMLUnknownElementVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTMLnpm run buildnpm testnpm run format:checkgit diff --check