refactor: establish DOMNodes folder feature - #326
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b79918593
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-dom-nodes-folder
branch
3 times, most recently
from
August 5, 2026 12:31
a6e3d1b to
cce8ba0
Compare
jderochervlk
force-pushed
the
codex/option5-dom-nodes-folder
branch
from
August 5, 2026 12:34
cce8ba0 to
88bf074
Compare
jderochervlk
force-pushed
the
codex/option5-dom-nodes-folder
branch
3 times, most recently
from
August 5, 2026 14:00
a1b8b2a to
e24fc87
Compare
jderochervlk
force-pushed
the
codex/option5-dom-nodes-folder
branch
2 times, most recently
from
August 5, 2026 14:50
3f7450a to
81a23b6
Compare
jderochervlk
force-pushed
the
codex/option5-dom-nodes-folder
branch
from
August 5, 2026 15:09
81a23b6 to
c680b86
Compare
jderochervlk
force-pushed
the
codex/option5-dom-nodes-folder
branch
from
August 5, 2026 15:45
c680b86 to
2f831d3
Compare
jderochervlk
force-pushed
the
codex/option5-dom-nodes-folder
branch
from
August 5, 2026 17:40
2f831d3 to
20849cd
Compare
jderochervlk
force-pushed
the
codex/option5-dom-nodes-folder
branch
2 times, most recently
from
August 6, 2026 14:58
05b3738 to
8530bf3
Compare
jderochervlk
force-pushed
the
codex/option5-dom-nodes-folder
branch
from
August 6, 2026 15:04
8530bf3 to
f44af83
Compare
jderochervlk
force-pushed
the
codex/option5-dom-nodes-folder
branch
from
August 6, 2026 17:19
f44af83 to
13f452f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 16 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #325.
Summary
src/dom-nodesfolder on the unqualified internalDOMNodesfeatureHTML.resshadow-root/serialization options module with its direct Element and ShadowRoot consumersWebAPI.DOMNodesfeatureAbstractRange,Attr,CDATASection,ProcessingInstruction, andStaticRangeinterface modulesDependency direction
The compiler-derived closure is:
WebAPI.DOMNodes -> WebAPI.DOMPlatform + WebAPI.Animation + WebAPI.CSSOM + WebAPI.Geometry + DOMNodesAnimation and CSSOM are required by public Element, ShadowRoot, ProcessingInstruction, and recursive DOMTree signatures. Keeping those dependencies explicit avoids module slices and produces an acyclic graph.
Temporary state
WebAPI.DOMsource-feature collision remains until the legacy DOM folder is fully emptiedDOM.*compatibility types; final type ownership cleanup remains deferredHTML.resis intentionally owned by DOMNodes because its option types are required there; the later HTML feature receives it transitivelyReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodesnpm run buildnpm testnpm run format:checkgit diff --check