Skip to content

refactor: establish Crypto folder feature - #317

Open
jderochervlk wants to merge 1 commit into
codex/option5-view-transitions-folderfrom
codex/option5-crypto-folder
Open

refactor: establish Crypto folder feature#317
jderochervlk wants to merge 1 commit into
codex/option5-view-transitions-folderfrom
codex/option5-crypto-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 7 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #316.

Summary

  • rename src/WebCrypto to the target src/crypto folder
  • change the folder to the unqualified internal Crypto feature
  • add the supported WebAPI.Crypto feature with its WebAPI.DOM dependency
  • preserve the flat WebAPI.Crypto and WebAPI.SubtleCrypto modules

The internal WebCryptoTypes helper remains private inside the complete folder.

Temporary state

  • this PR does not introduce compatibility aliases, file exclusions, or module slices; the Crypto folder and feature ownership are final
  • the typed-array helper it uses remains in core until the final ownership cleanup determines whether that broadly shared type should stay foundational

Review focus

  • the WebAPI.Crypto -> WebAPI.DOM + Crypto implication
  • unchanged public Crypto APIs and module paths
  • complete folder ownership

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Crypto
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac809614fc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
Comment thread rescript.json
@jderochervlk
jderochervlk force-pushed the codex/option5-crypto-folder branch from ac80961 to 8b2c9b2 Compare August 4, 2026 17:31
@jderochervlk
jderochervlk force-pushed the codex/option5-crypto-folder branch from 8b2c9b2 to 4511edb Compare August 5, 2026 12:14
@jderochervlk
jderochervlk force-pushed the codex/option5-crypto-folder branch from 4511edb to bcc8e3c Compare August 5, 2026 12:31
@jderochervlk
jderochervlk force-pushed the codex/option5-crypto-folder branch from bcc8e3c to 1758866 Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/option5-crypto-folder branch 2 times, most recently from 1756d67 to 973ac89 Compare August 5, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-crypto-folder branch 2 times, most recently from eb7e05b to 61892b8 Compare August 5, 2026 14:30
@jderochervlk
jderochervlk force-pushed the codex/option5-crypto-folder branch from 61892b8 to 859a8af Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-crypto-folder branch 2 times, most recently from fa1cd34 to 63bfc20 Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-crypto-folder branch from 63bfc20 to abf585f Compare August 5, 2026 17:39
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-crypto-folder branch from abf585f to 0e35d88 Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-crypto-folder branch from 0e35d88 to 0a85511 Compare August 6, 2026 14:58
@jderochervlk
jderochervlk force-pushed the codex/option5-crypto-folder branch from 0a85511 to 64127ba Compare August 6, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant