Skip to content

Fix remote-data test workflow - #2840

Merged
kandersolar merged 1 commit into
pvlib:mainfrom
kandersolar:fix-remote-data-ci
Aug 5, 2026
Merged

Fix remote-data test workflow#2840
kandersolar merged 1 commit into
pvlib:mainfrom
kandersolar:fix-remote-data-ci

Conversation

@kandersolar

Copy link
Copy Markdown
Member
  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The latest remote-data workflows are failing with this message:

Error: Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

I've reviewed the linked page and think it's fine for us to use allow-unsafe-pr-checkout in this case because we manually review iotools PRs before triggering this workflow (see the notes at the top of the workflow file for more details). I think this is our best option.

I will merge without review so that #2836 and #2839 are not stuck.

@kandersolar kandersolar added this to the v0.16.0 milestone Aug 5, 2026
@kandersolar
kandersolar merged commit d48bfec into pvlib:main Aug 5, 2026
26 of 27 checks passed
@kandersolar
kandersolar deleted the fix-remote-data-ci branch August 5, 2026 11:50
@kandersolar kandersolar mentioned this pull request Aug 5, 2026
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant