Skip to content

Add get_surfrad iotools function - #2836

Open
IoannisSifnaios wants to merge 14 commits into
pvlib:mainfrom
IoannisSifnaios:get_surfrad_function
Open

Add get_surfrad iotools function#2836
IoannisSifnaios wants to merge 14 commits into
pvlib:mainfrom
IoannisSifnaios:get_surfrad_function

Conversation

@IoannisSifnaios

@IoannisSifnaios IoannisSifnaios commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Closes SURFRAD site & date-range download #1155
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Add pvlib.iotools.get_surfrad function.

@IoannisSifnaios
IoannisSifnaios marked this pull request as draft August 4, 2026 15:37
@IoannisSifnaios IoannisSifnaios added this to the v0.15.3 milestone Aug 4, 2026
@IoannisSifnaios IoannisSifnaios added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Aug 4, 2026
@IoannisSifnaios IoannisSifnaios added the remote-data triggers --remote-data pytests label Aug 4, 2026
@IoannisSifnaios
IoannisSifnaios marked this pull request as ready for review August 4, 2026 17:18
@IoannisSifnaios

IoannisSifnaios commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

@AdamRJensen unclear why the remote-data tests fail. But otherwise, ready for review!

@AdamRJensen AdamRJensen modified the milestones: v0.15.3, v0.16.0 Aug 5, 2026
@kandersolar kandersolar mentioned this pull request Aug 5, 2026
Merged
9 tasks
AdamRJensen
AdamRJensen reviewed Aug 5, 2026
View reviewed changes
Comment thread docs/sphinx/source/whatsnew/v0.15.3.rst Outdated
AdamRJensen
AdamRJensen reviewed Aug 5, 2026
View reviewed changes
Comment thread pvlib/iotools/surfrad.py Outdated
AdamRJensen
AdamRJensen approved these changes Aug 5, 2026
View reviewed changes
Comment thread tests/iotools/test_surfrad.py
@kandersolar

kandersolar commented Aug 5, 2026

Copy link
Copy Markdown
Member

unclear why the remote-data tests fail

should be fixed by #2840 if you update this branch from pvlib:main

IoannisSifnaios and others added 5 commits August 5, 2026 16:29
@IoannisSifnaios
Merge remote-tracking branch 'upstream/main' into get_surfrad_function
981884c
@IoannisSifnaios @AdamRJensen
Update docs/sphinx/source/whatsnew/v0.15.3.rst
759dd8f 
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
@IoannisSifnaios @AdamRJensen
Update pvlib/iotools/surfrad.py
0deed99 
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
@IoannisSifnaios @AdamRJensen
Update tests/iotools/test_surfrad.py
1d02f71 
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
@IoannisSifnaios
Update test_surfrad.py
5403d15
kandersolar
kandersolar approved these changes Aug 5, 2026
View reviewed changes

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pvlib/iotools/surfrad.py Outdated
@IoannisSifnaios @kandersolar
Update pvlib/iotools/surfrad.py
dcf5864 
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
@IoannisSifnaios IoannisSifnaios added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Aug 5, 2026
@IoannisSifnaios

IoannisSifnaios commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

The test failures are in test_merra2.py, so unrelated to this PR. Ready for merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdamRJensen AdamRJensen AdamRJensen approved these changes
@kandersolar kandersolar kandersolar approved these changes

Assignees

No one assigned

Labels

io remote-data triggers --remote-data pytests

Projects

None yet

Milestone

v0.16.0

Development

Successfully merging this pull request may close these issues.

SURFRAD site & date-range download

3 participants

@IoannisSifnaios @kandersolar @AdamRJensen