Skip to content

Migrate custom/pcaclustering, custom/clustermetrics and custom/clustervisualization - #12771

Open
dbaku42 wants to merge 14 commits into
nf-core:masterfrom
dbaku42:migrate-custom-clustering-to-topics-clean
Open

Migrate custom/pcaclustering, custom/clustermetrics and custom/clustervisualization#12771
dbaku42 wants to merge 14 commits into
nf-core:masterfrom
dbaku42:migrate-custom-clustering-to-topics-clean

Conversation

@dbaku42

@dbaku42 dbaku42 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Description

Migrates the three custom modules used by the snpclustering subworkflow to topic channels:

  • custom/pcaclustering
  • custom/clustermetrics
  • custom/clustervisualization

These modules use the template directive, so they keep generating versions.yml and emit it with topic: versions (the recommended transitional style).

This allows the snpclustering subworkflow PR (#11879) to remain clean and avoid needing a second update after these modules are migrated.

Related PR

Related to #11879

Checklist

  • Modules emit versions with topic: versions
  • meta.yml files updated with correct topics section
  • Tests updated and passing
  • No changes to the snpclustering subworkflow in this PR

@dbaku42
dbaku42 requested review from 3nrique0, 3ru and 4less August 21, 2026 14:41
@dbaku42 dbaku42 self-assigned this Aug 21, 2026

@LouisLeNezet LouisLeNezet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it needed ?

Comment thread modules/nf-core/custom/clustermetrics/meta.yml
Comment thread modules/nf-core/custom/clustervisualization/meta.yml
Comment thread modules/nf-core/custom/pcaclustering/meta.yml
Comment thread modules/nf-core/custom/clustervisualization/tests/main.nf.test Outdated

@LouisLeNezet LouisLeNezet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes needed

Comment thread modules/nf-core/custom/clustervisualization/tests/main.nf.test
Comment thread modules/nf-core/custom/clustermetrics/meta.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants