Remove temporary text/node highlighting that can permanently recolor nodes - #179
Open
dankinsoid wants to merge 1 commit into
Open
Remove temporary text/node highlighting that can permanently recolor nodes#179dankinsoid wants to merge 1 commit into
dankinsoid wants to merge 1 commit into
Conversation
The orange highlight applied during scan_text_nodes, set_multiple_text_contents, and get_reactions saved/restored fills (or strokes) around a delay. If the op threw or aborted before restore, the node kept the highlight color permanently, breaking components. Removed all four highlight blocks; core logic untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
juansilvadesign
added a commit
to juansilvadesign/cursor-talk-to-figma-mcp
that referenced
this pull request
Jul 10, 2026
…rab#179) + export format fix (grab#146) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XFKprMCkUsAZfvcM9Uhjax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scan_text_nodes,set_multiple_text_contents, andget_reactionsapply a temporary orange highlight to nodes for visual feedback. The pattern saves the originalfills/strokes, overwrites them, waits viadelay()/setTimeout, then restores.If the operation throws or the plugin run is interrupted between the overwrite and the restore, the node keeps the orange highlight permanently — leaving text recolored and breaking components.
Fix
Removed all four highlight blocks in
src/cursor_mcp_plugin/code.js:get_reactions— orange stroke + 1.5ssetTimeoutscan_text_nodes— orange fill, 100msfindTextNodes(legacy) — orange fill, 500msset_multiple_text_contents— orange fill, 500msCore scanning / text-replacement logic is untouched; only the cosmetic feedback is gone.
node --checkpasses.🤖 Generated with Claude Code