fix: stop scan/reactions from leaving nodes permanently recolored (+ honor export format) - #184
Open
juansilvadesign wants to merge 3 commits into
Open
fix: stop scan/reactions from leaving nodes permanently recolored (+ honor export format)#184juansilvadesign wants to merge 3 commits into
juansilvadesign wants to merge 3 commits into
Conversation
The orange highlight applied during scan_text_nodes, set_multiple_text_contents, and get_reactions saved/restored fills (or strokes) around a delay. If the op threw or aborted before restore, the node kept the highlight color permanently, breaking components. Removed all four highlight blocks; core logic untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Friendly ping on this one — it's been open since July and still merges cleanly against Happy to rebase or split it further if that makes review easier. For context, I've just opened #186 ( Thanks for merging #185. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bundles two open community fixes that protect nodes during read operations. Both commits keep their original authorship (cherry-picked, not squashed).
Included work
get_reactionsandscan_text_nodestemporarily recolor each node to show progress, swappingfillsthroughJSON.parse(JSON.stringify(...))(which drops variable bindings) and restoring on a timer. If the plugin is closed or throws mid-scan, the nodes stay recolored — permanently, with their variable bindings lost. This removes the highlighting entirely.params.formatinexportNodeAsImage(author: @bimawa)Export was effectively hardcoded to PNG; this respects the requested format.
Why bundle them
Both are small, safe correctness fixes on the read path, with no change to tool names or signatures. Grouping them keeps review to one coherent "don't mutate what you're only reading" theme. These touch only the plugin (
code.js); the MCP server bundle is unaffected.Credit to the original authors — this branch only reconciles their commits onto current
main.