Skip to content

fix(routes/partners.netlify): replace 'lucide-react' icons with phosphor - #1113

Merged
sukvvon merged 2 commits into
mainfrom
fix/netlify-partner-icons
Aug 5, 2026
Merged

fix(routes/partners.netlify): replace 'lucide-react' icons with phosphor#1113
sukvvon merged 2 commits into
mainfrom
fix/netlify-partner-icons

Conversation

@sukvvon

@sukvvon sukvvon commented Aug 5, 2026

Copy link
Copy Markdown
Member

partners.netlify.tsx imports twelve icons from lucide-react, but that package is not in package.json. Lint fails on main:

x typescript(TS2307): Cannot find module 'lucide-react' or its corresponding type declarations.
    ,-[src/routes/partners.netlify.tsx:16:8]

This is the only file in src/ that reaches for lucide-react; every other icon on the site comes from @phosphor-icons/react.

Fix

Swapped all twelve for their phosphor equivalents. partners.railway.tsx — the sibling partner page — already maps almost this exact set, so the pairings follow it:

lucide phosphor
ArrowUpRight ArrowUpRightIcon
Check CheckIcon
DollarSign CurrencyDollarIcon
GitPullRequest GitPullRequestIcon
Globe GlobeIcon
Infinity InfinityIcon
LineChart ChartLineIcon
Plus PlusIcon
Rocket RocketIcon
ShieldCheck ShieldCheckIcon
Undo2 ArrowUUpLeftIcon
Zap LightningIcon

Zap is the one pairing railway does not already have; LightningIcon is what the rest of the site uses for that concept (routes/index.tsx, landing/DbLanding.tsx).

Names are used unaliased, matching the convention established in #1094 rather than railway's X as Y aliases.

Verified

pnpm exec oxlint --type-aware now reports 0 errors across 916 files — it reported 1 before. tsc is clean for this file.

Left alone: strokeWidth={3} on the check badge is inert for phosphor, but partners.railway.tsx carries the same leftover, so tidying it belongs in a pass over both.

Summary by CodeRabbit

  • Style
    • Updated icons throughout the Netlify partner page for a more consistent visual appearance.
    • Page content, functionality, and behavior remain unchanged.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f28b8d16-f1e9-4472-8590-9d316dabd905

📥 Commits

Reviewing files that changed from the base of the PR and between 07e83b2 and d25fb83.

📒 Files selected for processing (1)
  • src/routes/partners.netlify.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/routes/partners.netlify.tsx

📝 Walkthrough

Walkthrough

The Netlify partner page replaces Lucide icons with corresponding Phosphor icons across feature sections, badges, CTA links, pricing, testimonials, and FAQ controls. Page content and behavior remain unchanged.

Changes

Netlify icon migration

Layer / File(s) Summary
Replace page icons
src/routes/partners.netlify.tsx
The page imports and uses Phosphor components for feature icons, check badges, CTA arrows, the currency indicator, and FAQ expansion controls.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes replacing Lucide icons with Phosphor icons in the Netlify partner route.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/netlify-partner-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sukvvon
sukvvon requested a review from a team August 5, 2026 00:55
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 5, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com d25fb83 Commit Preview URL

Branch Preview URL
Aug 05 2026, 01:03 AM

@sukvvon sukvvon self-assigned this Aug 5, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/routes/partners.netlify.tsx`:
- Line 312: Update the CheckIcon usage to replace strokeWidth={3} with
Phosphor’s weight="bold" prop, preserving the intended heavier check appearance.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a2892caa-bfdd-462b-a8f2-24c3cdcb5f28

📥 Commits

Reviewing files that changed from the base of the PR and between 476a3ae and 07e83b2.

📒 Files selected for processing (1)
  • src/routes/partners.netlify.tsx

Comment thread src/routes/partners.netlify.tsx Outdated
@sukvvon
sukvvon merged commit 3321b67 into main Aug 5, 2026
7 checks passed
@sukvvon
sukvvon deleted the fix/netlify-partner-icons branch August 5, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants