refactor(routes/partners.railway): drop lucide-era icon aliases and fix the check weight - #1114
Conversation
…ix the check weight
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Railway partner route now imports current Phosphor icon names directly. Icon usages and the check icon property were updated without changing behavior or rendering. ChangesRailway partner icon updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | fe940ae | Commit Preview URL Branch Preview URL |
Aug 05 2026, 02:53 AM |
Follow-up to #1113, which moved the Netlify partner page off
lucide-react. The Railway page had migrated to Phosphor earlier but kept two artefacts from that move.strokeWidth={3}never appliedThe check badge carried
strokeWidth={3}— a Lucide prop. Phosphor'sIconPropshas nostrokeWidth; it exposesweight, and each weight ships a different SVG path. The prop was silently dropped and the check rendered atregular.Confirmed by reading the rendered path:
dattributestrokeWidth={3}M229.66,77.66l-128,128a8,8,…weight="bold"M232.49,80.49l-128,128a12,12,…So this restores the emphasis the badge had under Lucide rather than changing the design.
Aliases
These preserved the old Lucide names. With #1113 landed, the two partner pages otherwise use identical Phosphor imports, so keeping the aliases here meant the same icon went by two names depending on the file. Call sites updated and the import block re-sorted.
Verified
tscandoxlint --type-awareclean. Rendered the page locally and diffed the badge's SVG path before and after to confirmweighttakes effect — the visual difference at 10px is too small to judge from a screenshot alone.Summary by CodeRabbit