Skip to content

Let DockerSessionListener subclasses route their own container stop #7956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-tchad merged 1 commit into from
Aug 21, 2026
Merged

Let DockerSessionListener subclasses route their own container stop #7956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion api/src/org/labkey/api/docker/DockerSessionListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public void valueUnbound(HttpSessionBindingEvent httpSessionBindingEvent)

try
{
DockerService.get().stop(_containerId);
stopContainer(_containerId);
}
catch (Exception ex)
{
Expand All @@ -57,4 +57,13 @@ public void valueUnbound(HttpSessionBindingEvent httpSessionBindingEvent)
}

protected void preStop() {}

/**
* Override to route the stop through a service-specific manager (e.g. DockerRStudioManager) when one tracks
* its own cache of containers; the default here stops via DockerService directly, leaving such a cache stale.
*/
protected void stopContainer(@NotNull String containerId)
{
DockerService.get().stop(containerId);
}
}