Let DockerSessionListener subclasses route their own container stop - #7956
Merged
Conversation
DockerSessionListener.valueUnbound() stopped containers via DockerService directly, so RStudioSessionListener (the only subclass) never told DockerRStudioManager to invalidate its cached process for that container. Added an overridable stopContainer() hook so subclasses with their own container cache can stay consistent.
XingY
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
DockerSessionListener.valueUnbound()always stopped a container via the genericDockerService, so a subclass that keeps its own cache of tracked containers (like RStudio'sDockerRStudioManager) had no way to keep that cache in sync when a container was stopped this way.Related Pull Requests
Changes
stopContainer()hook thatvalueUnbound()calls instead of hard-codingDockerService.get().stop(); default behavior is unchanged for existing callers.