Repair #232 rustfmt and psychometric test arity - #240
Closed
seonghobae wants to merge 7 commits into
Closed
Conversation
Protected-main rust-quality fails cargo fmt --all --check on the consolidated event_time unit tests and multilevel recovery contract. Formatting only; call-site arity is a follow-up commit. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Voelkle Eq. 14 now takes event, sampling, and constancy intervals. Stale 3-arg calls repeat the existing event interval so sampling = constancy = event, matching scientific_claim_boundary_contract.rs. Same-interval remapping passes source_delta as reference_delta. Zero predictor/variance asymptotic calls insert the licensed 0 log-rate; negative TIPREDVAR keeps the existing v < 0 refusal. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
…d call arities Insert licensed zeros for intercept, manifest-mean, predictor, and measurement extras, and restore missing t-u/Δt from each test so overflow and refusal assertions keep the same Ok/Err variant. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Apply the same licensed-zero and existing-interval inserts to the remaining event_time.rs unit-test calls that the first pass missed because of indentation. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
…ent arity Complete the last recover_stationary_later_latent_variance and trait-only initial-variance call sites so B/v slots are explicit zeros and printed LeisureTime TIPREDEFFECT -0.225 stays in the B slot. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
… sites Remove three short MAX overflow calls that duplicated the sibling (B=1, v=MAX, a=-1) pattern after the #232 signature growth, and pad later-lagged / later-start-later latent overflow calls with licensed zeros so workspace rust-quality can compile. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
…rflow Trait = MAX with q = B = v = 0 is a finite composition after the #232 signature growth. Overflow remains covered by the sibling (B=1, v=MAX, a=-1) assertions in the same fail-closed tests. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Contributor
Author
|
Superseded by the protected-main restructure. This repair targeted the pre-consolidation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge
0ce16e88on protected main restoredpsychometric_coreto the last known-good pre-#232-consolidation tree so main compiles again. This branch was a compile/format vehicle for the post-consolidation signatures. Rebasing or merging it would re-apply stale grown-signature call pads onto the restored sources and re-break rust-quality.Keep this draft closed-to-merge.
#238 is closed (superseded by #241). Coverage of the unreachable
is_image_media_type_tokenlet-else is now #241’sunwrap_or_defaultrewrite, not a private-helper unit test.Original why (historical)
Protected-main Rust Foundation CI on
07c8d236(#232 merge) could not compile:psychometric_coreE0061arity mismatches after production signatures grewThose symptoms are gone on
c482cceabecause the consolidation union was reverted, not because this arity pad should land.Local evidence on this obsolete head (
6613ee5a):cargo test -p psychometric_core --all-featurespassed against the post-consolidation signatures. That is not a license to merge onto restored main.Strix red on this branch is not product CI. Not full #167 closure.