Skip to content

Fold span grounding into EventMention (#170 / GAP-007) - #233

Draft
seonghobae wants to merge 3 commits into
mainfrom
cursor/span-grounded-mentions-a17b
Draft

Fold span grounding into EventMention (#170 / GAP-007)#233
seonghobae wants to merge 3 commits into
mainfrom
cursor/span-grounded-mentions-a17b

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Product slice

Issue #170 / GAP-007 asked for one calibrated TDT + CHRONOS product workflow. On current protected main (c482ccea), event_core already has isolated mention/instance types plus first-story FAR/miss, link P/R, tracking P/R, WindowDiff/Pk, schema-slot P/R, and CHRONOS Brier scoring.

The missing #170 contract implemented here is span-grounded EventMention:

  • EventMention is the only constructible mention type; there is no second unused mention type that can be built without a span
  • each mention cites one exact SourceSpan, document identity, six-clock evidence, extractor/model version, and proposed/reviewed status
  • surface text is the document substring at that span
  • availability after knowledge cutoff fails closed; delayed reporting at or before cutoff is kept
  • reviewed status is inspection, not instance promotion
  • link, track, instance, registry, and first-story consumers construct grounded mentions
  • exact-extent precision/recall recover known ACE extents (occupancy RMSE 0) and beat a whole-document extractor (RMSE 1)

This is not another identity gate and does not reimplement #226/#230/#231/#232/#239. Other-agent #235/#236/#237/#238/#240/#241 are left alone. psychometric_core and network_analysis are identical to origin/main. Workspace 0.2.0 versions are inherited from main. The EventMention CHANGELOG line stays under [Unreleased].

Remaining #170 work

Unified TDT/CHRONOS workflow composition, Allen/CHRONOS interval consistency, persistence, and versioned JSON/JSON-LD/GraphML exports.

Verification

  • Rebased onto origin/main c482ccea
  • cargo fmt -- --check is clean
  • cargo check --workspace --tests compiles
  • cargo test -p event_core passed
  • event_core authored LCOV: mention.rs 131/131, span_mention.rs 170/170, error.rs 147/147

Draft until exact-head TEPP product CI is green (Format/lint/test/rustdoc, production line/branch coverage, live-postgres, Repository contracts and Python branch coverage, Validate planning).

Sources

Doddington et al. (2004) ACE extent mapping; Allan (2002) detection-vs-instance; Jensen & Snodgrass (1999) availability vs event time. Numeric provenance: docs/doctoring/span-grounded-mentions.md.

Open in Web Open in Cursor 

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot changed the title Add span-grounded event mentions with exact-extent recovery (#170 / GAP-007) Fold span grounding into EventMention (#170 / GAP-007) Aug 25, 2026
@cursor
cursor Bot force-pushed the cursor/span-grounded-mentions-a17b branch from 4223fb1 to 0bbd116 Compare August 25, 2026 09:11
cursoragent and others added 3 commits August 25, 2026 10:04
Protected main already isolates TDT/CHRONOS scoring gates. Mentions still
lacked exact source extents. This slice binds each mention to one SourceSpan,
six-clock cutoff evidence, extractor version, and review status, and scores
ACE exact-extent precision/recall against known documentary truth.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Close remaining fail-closed and half-rate paths on span-grounded mention
scoring so exact-extent recovery stays fully exercised.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Issue #170 requires every mention to cite an exact source span. Remove the unused parallel mention type so EventMention can be constructed only from a document span, six-clock evidence, extractor version, and review status.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/span-grounded-mentions-a17b branch from 0bbd116 to 0a86d8d Compare August 25, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants