Fold span grounding into EventMention (#170 / GAP-007) - #233
Draft
seonghobae wants to merge 3 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cursor
Bot
force-pushed
the
cursor/span-grounded-mentions-a17b
branch
from
August 25, 2026 09:11
4223fb1 to
0bbd116
Compare
Protected main already isolates TDT/CHRONOS scoring gates. Mentions still lacked exact source extents. This slice binds each mention to one SourceSpan, six-clock cutoff evidence, extractor version, and review status, and scores ACE exact-extent precision/recall against known documentary truth. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Close remaining fail-closed and half-rate paths on span-grounded mention scoring so exact-extent recovery stays fully exercised. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Issue #170 requires every mention to cite an exact source span. Remove the unused parallel mention type so EventMention can be constructed only from a document span, six-clock evidence, extractor version, and review status. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/span-grounded-mentions-a17b
branch
from
August 25, 2026 10:04
0bbd116 to
0a86d8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product slice
Issue #170 / GAP-007 asked for one calibrated TDT + CHRONOS product workflow. On current protected
main(c482ccea),event_corealready has isolated mention/instance types plus first-story FAR/miss, link P/R, tracking P/R,WindowDiff/Pk, schema-slot P/R, and CHRONOS Brier scoring.The missing #170 contract implemented here is span-grounded
EventMention:EventMentionis the only constructible mention type; there is no second unused mention type that can be built without a spanSourceSpan, document identity, six-clock evidence, extractor/model version, and proposed/reviewed statusThis is not another identity gate and does not reimplement #226/#230/#231/#232/#239. Other-agent #235/#236/#237/#238/#240/#241 are left alone.
psychometric_coreandnetwork_analysisare identical toorigin/main. Workspace 0.2.0 versions are inherited from main. The EventMention CHANGELOG line stays under[Unreleased].Remaining #170 work
Unified TDT/CHRONOS workflow composition, Allen/CHRONOS interval consistency, persistence, and versioned JSON/JSON-LD/GraphML exports.
Verification
origin/mainc482cceacargo fmt -- --checkis cleancargo check --workspace --testscompilescargo test -p event_corepassedevent_coreauthored LCOV:mention.rs131/131,span_mention.rs170/170,error.rs147/147Draft until exact-head TEPP product CI is green (Format/lint/test/rustdoc, production line/branch coverage, live-postgres, Repository contracts and Python branch coverage, Validate planning).
Sources
Doddington et al. (2004) ACE extent mapping; Allan (2002) detection-vs-instance; Jensen & Snodgrass (1999) availability vs event time. Numeric provenance:
docs/doctoring/span-grounded-mentions.md.