docs: record ADRs for the Ask Agent temporal/lineage/evidence goal - #422
Merged
Conversation
Four new ADRs, one per checkpoint of the Ask Agent temporal/lineage/ evidence goal: - 0119: Korean relative-time expression resolution (#415) - 0120: multi-thread Event Lineage graphs in Ask answers (#418) - 0121: image citation without a new image-serving surface (#419) - 0122: the evidence Layer Popup (#420) Update CHANGELOG.md's Unreleased section and add an "Ask Agent Gaps" section to docs/product-technical-gap-baseline.md marking all four gaps (plus e2e coverage, #421) resolved, following that file's existing "(Resolved)" convention. Part of the Ask Agent temporal/lineage/evidence goal (checkpoint 6 of 6 -- documentation).
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
seonghobae
enabled auto-merge (squash)
August 23, 2026 06:41
…k' into repair/pr422-frontend-root-3
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Cross-session coordination surfaced a widespread ADR-numbering collision: at least ten numbers between 0119 and 0143 are independently claimed by concurrent unmerged branches across other sessions (0127/0128/0129/0131/0132 each claimed 2-4x, per `git log --all --diff-filter=A -- docs/adr`). This PR's own 0119-0122 was a three-way collision (also claimed by the TEPP topic-lineage PR and a quantity-superscript PR). Since this PR only holds 4 ADRs against another's 14 (0119-0132), renumbering here is the smaller diff. Moved clear of every number seen across all branches (highest observed: 0143), leaving buffer room. No content changes -- only the ADR number in each file's title, their mutual cross-references, and every CHANGELOG.md / gap-baseline.md citation of the old numbers.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Two TypeScript build errors on main (blocking every open PR's
"Frontend lint, test, build" check, including this repo's own review
bot's ability to approve them):
- App.tsx imported rememberOidcReturnUrl/returnUrlFromLocation from
oidcReturnUrl.ts but never called them -- the login button built its
own unsanitized returnUrl inline instead of using the safe helper
(oidcReturnUrl.ts's isSafeReturnUrl guard against an open-redirect-
shaped value) or persisting it as the sessionStorage/localStorage
fallback restoreOidcReturnUrl (already wired up on the callback side
in main.tsx) reads when the OIDC state round-trip drops it.
- The unauthenticated login screen unconditionally rendered
<AdminPanel accessToken={accessToken} /> when destination === "admin"
-- accessToken is string | undefined here (always undefined while
unauthenticated), a real type error, and the render was unreachable
through normal navigation (destination only changes via the
authenticated nav) -- dead code, removed.
uv run --frozen python -m pytest -q: 753 passed, 17 skipped.
pnpm run test: 140 passed. pnpm run lint / build: clean.
# Conflicts: # docs/product-technical-gap-baseline.md
Contributor
Author
|
Exact-head review requested for |
# Conflicts: # CHANGELOG.md # docs/product-technical-gap-baseline.md
This was referenced Aug 24, 2026
seonghobae
added a commit
that referenced
this pull request
Aug 24, 2026
…-source-detail-state-filter origin/main moved 58 commits ahead mid-session, including a properly reviewed and tested implementation of the same evidence-layer-popup feature this branch had manually rebuilt (#419). Re-merged to pick it up rather than ship a parallel, untested version. Resolved 7 conflicts: - backend/app/post_chat_ingestion.py: combined this branch's ABAC/candidate-id filtering with main's Korean relative-time date-range filter on the same source_post query; combined both sides' import additions (tepp_client + temporal_expressions). - backend/app/lineage_ingestion.py: combined this branch's isolation_reason (ADR 0143) with main's include_isolated parameter and new lineage_graphs_for_posts merge function -- both needed together, not alternatives. - backend/app/main.py: added the lineage_graph computation (from main's dropped PR #418) into this branch's persist_turn-based ask_agent flow, using response["cited_post_ids"] so it works for both the sources-empty and populated-sources paths. - frontend/src/App.tsx: kept this branch's working multi-turn (exchanges.map()) Ask Agent implementation wholesale over main's incompatible pre-refactor single-answer fragment; added the missing <LineageDag> rendering for response.lineage_graph per exchange, and kept the richer TenantConfig AdminPanel wiring already established. - tests/test_lineage_ingestion.py, tests/test_global_ask_sources.py, CHANGELOG.md: reconstructed interleaved additive conflicts as complete, non-overlapping test functions / changelog entries from both sides. Also fixed real bugs surfaced along the way: - cited_post_images() (backend/app/post_chat_ingestion.py) queried the pre-rename image.caption column; migration 0104 renamed it to image_caption. Fixed the SQL and row mapping, matching how /api/posts/{id}/content already does it. - Two tenant-settings tests asserted the old single-brandName response shape instead of the current {brandName, systemName, copyrightYear, copyrightHolder} contract. - A stale test fixture in tests/test_post_chat_ingestion.py still keyed its fake DB rows by the pre-rename "caption" column. - Fixed a duplicate ADR 0119 number (retire-buyer-terminology -> 0168; leftover-map-two-dimensional-distance already owned 0119). - A LineageDag.test.tsx role="group" vs a newly-merged App.test.tsx role="img" mismatch: kept role="group" (this branch's existing, better-tested LineageDag.tsx choice, verified by 4 passing assertions) and updated the one new test instead. Verified: tests/ (1037 passed, 11 skipped), backend/tests/ (156 passed, 5 skipped -- orchestrator-gated), frontend (469 passed), tsc -b clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NpWw9SnPBaemFZmW3fdTVM
seonghobae
added a commit
that referenced
this pull request
Aug 24, 2026
- Snapshot: protected main 63876eb (#422), 37 open PRs, 19 open issues. - Record the org-wide Strix provider failure (NIM ~70s / OpenAI-direct ~5s exits) and its durable repair ContextualWisdomLab/.github#1263, including the ten base-merged paths the prior merge commit had reverted and how they were restored. - Record the ADR 0109 shared login repair applied to eight pre-repair branches (#521, #522, #552-556 set, #558, #560), verified locally with frontend lint/test/build before each push. - Replace stale §3 inventory with the current 37-head queue grouped by product surface, SKOS/leftover-map ladder, repairs, integration, and docs. - Refresh §5 rows whose referenced PRs have since landed (#496/#507/#515, #544/#559 channel-weight hardening) and rewrite §10 as the autonomous ascending-order merge loop. - Note #368 closed as superseded. Co-authored-by: seonghobae <seonghobae@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Verification
uv run --extra dev pytest -q tests/test_documentation_hygiene.py(4 passed)git diff --checkNo real records, identifiers, provider credentials, or protected-merge claims are included.