Skip to content

fix: honor Whisper provider proxy - #9777

Open
casama233 wants to merge 1 commit into
AstrBotDevs:masterfrom
casama233:fix/whisper-stt-proxy
Open

fix: honor Whisper provider proxy#9777
casama233 wants to merge 1 commit into
AstrBotDevs:masterfrom
casama233:fix/whisper-stt-proxy

Conversation

@casama233

@casama233 casama233 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Modifications / 改动点

  • Pass the configured provider proxy to the Whisper STT OpenAI client.
  • Add regression coverage for proxy-aware client construction.
  • This is NOT a breaking change.

Screenshots or Test Results / 运行截图或测试结果

  • python -m pytest -q /tmp/test_whisper_api_source.py: 2 passed.
  • python -m ruff check ...: All checks passed.

Checklist / 检查清单

  • No new feature is introduced.
  • The change was tested and verification results are provided above.
  • No new dependencies are introduced.
  • The change does not introduce malicious code.

Summary by Sourcery

Route Whisper API requests through the provider-configured proxy and verify the client configuration.

Bug Fixes:

  • Honor the configured provider proxy when constructing the OpenAI Whisper STT client.

Tests:

  • Add regression coverage verifying that the configured proxy HTTP client is passed to the Whisper client.

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. area:provider The bug / feature is about AI Provider, Models, LLM Agent, LLM Agent Runner. labels Aug 22, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. If proxy construction or selection is wrong, Whisper audio and the API credential may be sent through an unintended intermediary, exposing data or access that a revert cannot undo. Reverting stops future requests from using the proxy, but it cannot retract requests already transmitted.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:provider The bug / feature is about AI Provider, Models, LLM Agent, LLM Agent Runner. size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant