fix(stt): honor Whisper provider proxy - #9776
Closed
casama233 wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. The change routes Whisper audio through the configured proxy, so a faulty or unintended proxy can expose submitted audio or prevent transcription requests from reaching the provider. Reverting stops the new routing behavior, but cannot undo audio that was already sent through the wrong proxy.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
Superseded by # to comply with the repository branch and PR template conventions. |
Contributor
Author
|
Superseded by #9777 to comply with the repository branch and PR template conventions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
python -m pytest -q /tmp/test_whisper_api_source.pySummary by Sourcery
Route Whisper STT requests through the configured provider proxy.
Bug Fixes:
Tests: