Add optional FixedScaleOffset dimension preservation - #853
Open
shixi-li wants to merge 1 commit into
Open
Conversation
shixi-li
marked this pull request as ready for review
August 11, 2026 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #852.
Summary
keep_dimensionsparameter toFixedScaleOffset, with the existing flattened output retained by defaultoutuses the opposite C/F memory orderValidation
uv run pytest -q tests/test_fixedscaleoffset.py— 15 passeduv run pytest -q— 654 passed, 32 optional-dependency skipsuv run ruff check src/numcodecs/fixedscaleoffset.py tests/test_fixedscaleoffset.pyuv run ruff format --check src/numcodecs/fixedscaleoffset.py tests/test_fixedscaleoffset.pyuv run mypy src/numcodecs/fixedscaleoffset.py tests/test_fixedscaleoffset.pygit diff --check-Wremains blocked by the current environment existing optional-codec imports and unrelated cross-reference warningsChecklist
docs/release.mdAI assistance
Codex assisted with test planning and independent review. I ran the tests and quality checks, inspected the final diff, and addressed a cross-memory-order
outregression found during review.