Skip to content

Report elapsed time in the success message - #136

Merged
swissspidy merged 2 commits into
mainfrom
feature/134-elapsed-time
Aug 10, 2026
Merged

Report elapsed time in the success message#136
swissspidy merged 2 commits into
mainfrom
feature/134-elapsed-time

Conversation

@BrianHenryIE

@BrianHenryIE BrianHenryIE commented Aug 10, 2026

Copy link
Copy Markdown
Member

Edit: I found it very helpful to see the time taken when working on #134 / #135:

Screenshot 2026-08-09 at 7 45 46 PM

This PR is a pretty simple end - start time() in __invoke().

Claude:

Implements the profiling suggestion from #134 ("Provide additional context/Screenshots"), as a follow-up to #135.

The success message now includes how long archive generation took, so slow runs (like the 8m32s in #134) are visible:

Success: Created bh-wp-bitcoin-gateway.2.0.0.zip (Size: 3.03 MB) in 0m 7s.
  • Dist_Archive_Command::__invoke() records the start time and appends in {minutes}m {seconds}s. to the success output, using the exact code suggested in the issue.
  • All 31 anchored STDOUT should match regexes in the Behat features are updated to expect the new suffix; the STDOUT should contain assertions are unaffected.

Ref #134

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Archive creation success messages now display the elapsed time in minutes and seconds.
    • Timing information is included for ZIP, TAR.GZ, plugin directory, and performance archive scenarios.

Append "in {minutes}m {seconds}s." to the success output, as suggested
in #134, so slow archive generation (e.g. #134's 8m32s) is visible.

Ref #134

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@BrianHenryIE
BrianHenryIE requested a review from a team as a code owner August 10, 2026 02:45
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@swissspidy, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 875ce056-3986-4d35-897f-cecb9d3c8726

📥 Commits

Reviewing files that changed from the base of the PR and between 8e211e6 and e4d5054.

📒 Files selected for processing (1)
  • features/distignore.feature
📝 Walkthrough

Walkthrough

The archive command now measures archive-generation time and includes minutes and seconds in successful ZIP and tarball messages. Feature scenarios in dist-archive.feature and distignore.feature require this output format.

Changes

Archive elapsed-time output

Layer / File(s) Summary
Timed archive success message
src/Dist_Archive_Command.php
The command records the start time and adds elapsed minutes and seconds to the success message.
Timed output feature assertions
features/dist-archive.feature, features/distignore.feature
Successful archive scenarios now require the elapsed-time suffix for ZIP and tarball output.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: command:dist-archive

Suggested reviewers: swissspidy

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding elapsed time to the archive success message.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/134-elapsed-time

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy

Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/Dist_Archive_Command.php`:
- Around line 184-188: Update the project’s Composer/PHPCS configuration so the
WP_CLI and WordPress coding-standard sniffs used by composer test are installed
and discoverable. Ensure composer test completes successfully without
missing-sniff errors, while preserving the existing validation commands.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a44ee168-0cce-4fd7-b00e-0028a015ec55

📥 Commits

Reviewing files that changed from the base of the PR and between 74d6ba9 and 8e211e6.

📒 Files selected for processing (3)
  • features/dist-archive.feature
  • features/distignore.feature
  • src/Dist_Archive_Command.php

Comment thread src/Dist_Archive_Command.php
@swissspidy swissspidy added this to the 3.3.0 milestone Aug 10, 2026
@swissspidy swissspidy added the command:dist-archive Related to 'dist-archive' command label Aug 10, 2026
@swissspidy
swissspidy merged commit 6c7f442 into main Aug 10, 2026
59 checks passed
@swissspidy
swissspidy deleted the feature/134-elapsed-time branch August 10, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:dist-archive Related to 'dist-archive' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants