feat: press ESC to unfocus PoC - #216
Draft
jficz wants to merge 1 commit into
Draft
Conversation
whyisdifficult
force-pushed
the
esc_to_unfocus
branch
from
May 6, 2026 18:15
c768ff6 to
462d500
Compare
PoC, addresses whyisdifficult#158
whyisdifficult
force-pushed
the
esc_to_unfocus
branch
from
June 3, 2026 14:54
8bfc769 to
84900ec
Compare
Contributor
|
@jficz @whyisdifficult Hey! Is this still being worked on? This feature is really important to me. And I will be happy to help if needed. |
Contributor
|
@whyisdifficult Hi again :) I've tried this approach, and it works well. It seems to me like a good starting point because unfocus on Escape looks like the expected behavior. I'd like to help with this PR |
Author
|
Thanks @samuelfirst ! It's not my place to speak for @whyisdifficult but if I were to make a recommendation, I'd merge this PR and collect feedback on where it does / doesn't work. If there are too many places where it doesn't, I would go with some kind of abstraction so we don't copypasta the same code around. |
Author
|
I'll rebase and review the PR again in the coming days to undraft it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoC, addresses #158