Skip to content

Readme updates - #80

Open
aarmam wants to merge 2 commits into
web-eid-mobilefrom
NFC-149
Open

Readme updates#80
aarmam wants to merge 2 commits into
web-eid-mobilefrom
NFC-149

Conversation

@aarmam

@aarmam aarmam commented Jul 27, 2026

Copy link
Copy Markdown

Signed-off-by: Mart Aarma mart.aarma@nortal.com

Sander Kondratjev and others added 2 commits July 27, 2026 15:50
Signed-off-by: Mart Aarma <mart.aarma@nortal.com>
@aarmam
aarmam requested a review from mrts July 27, 2026 13:36
@mrts mrts mentioned this pull request Aug 18, 2026
Comment thread README.md
JsonSerializer.Serialize(signingCertificate.SupportedSignatureAlgorithms)));
}

var identity = new ClaimsIdentity(claims, CookieAuthenticationDefaults.AuthenticationScheme);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we show an explicit application-specific authorization check stub before SignInAsync? Successful token validation establishes the user’s identity, but not their permission to access the service, this check is required before creating the authenticated session.

Comment thread README.md

The authentication protocol, validation requirements, authentication token format and nonce usage are described in more detail in the [Web eID system architecture document](https://github.com/web-eid/web-eid-system-architecture-doc#authentication-1).

# Authentication token format

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep the token schema in the canonical Web eID specification and limit this README to the formats supported by this library? Reproducing the field definitions here creates another normative-looking copy and already omits the 1.1 intermediate certificate fields. Illustrative examples could remain with a link to the canonical definition.

Comment thread README.md

The Web eID authentication protocol defines two token formats currently supported by this library:

- **Format v1.0** – Used in desktop Web eID authentication flows with traditional smart card readers.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web-eid:1.0 is not desktop-only, the mobile flow also uses it when signing certificate information is not requested. Could we describe it as the base authentication token format without signing certificate information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants