fix(create): avoid following target symlinks - #2418
Draft
leslieeilsel wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2419
Summary
lstatSyncinstead of following the final symbolic link.gitRoot cause
The availability check used
existsSyncfollowed byreaddirSync, so a directory symbolic link was treated as the directory it referenced. The cleanup loop then removed child paths through that link.existsSyncalso treated dangling links as missing, while existing regular files reached directory-only operations.Implementation
The target is now inspected with:
This keeps the final filesystem entry distinct from its destination:
The cleanup function performs a fresh
lstatSyncimmediately before mutation, so it also handles a target that disappears while the prompt is open.Validation
vitest run packages/cli/src/create/__tests__: 13 files, 185 tests passedtsc -p packages/cli/tsconfig.json --noEmitgit diff --checkRegression coverage includes real directories, links to empty and populated directories, dangling links, regular files, linked-target preservation, and the existing
.gitpreservation behavior.