fix(create): initialize git once for new monorepos - #2417
Draft
jong-kyung wants to merge 1 commit into
Draft
Conversation
Creating a new monorepo prompted for git initialization twice in verbose interactive mode and ran `git init` twice on the common path: once through a direct spawn right after scaffolding and again through `initGitRepository` after the monorepo rewrite. The second run also used the first prompt's answer, so answering no to the second prompt was silently overridden. Remove the duplicate prompt and keep a single `initGitRepository` call placed before the hook preflight, matching the standalone path, and move the failure warning into the shared helper so both paths report a failed `git init`.
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creating a new monorepo with
vp create vite:monorepohandled git initialization through two separate code paths, which caused three related problems:--git/--no-git, the user was prompted twice ("Initialize a git repository?" fromresolveGitInit, then "Initialize git repository:" inside the monorepo branch).initGitRepositorycall keyed off the first prompt's result.git initran twice: once via a directspawn.syncright after scaffolding and again viainitGitRepositoryafter the monorepo rewrite.Fix
resolveGitInitalready asks up front before scaffolding.initGitRepositorycall, placed before the hook preflight soshouldSkipStagedMigrationForHookssees the destination's intended git root (same reasoning as the standalone path).initGitRepositoryhelper so both the monorepo and standalone paths report a failedgit init.