feat: allow explicitly disabling Vite+'s Node.js version management with node-version: off - #115
feat: allow explicitly disabling Vite+'s Node.js version management with node-version: off#115KTrain5169 wants to merge 3 commits into
node-version: off#115Conversation
…ith `node-version: off`
There was a problem hiding this comment.
Pull request overview
Adds support for explicitly disabling Vite+ Node.js version management via the action input node-version: off, aimed at users who manage Node.js through other tooling.
Changes:
- Update main action flow to treat
node-version: offas a request to runvp env off. - Update
action.ymlinput documentation to mention theoffoption.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/index.ts |
Adds nodeVersion !== "off" guard and an else if branch to run vp env off. |
action.yml |
Updates node-version input description to mention off. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3376754c01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
turns out I forgot to push my packed dist/index.mjs |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
action.yml:25
- The
node-versioninput description still claims it "Defaults to Node.js latest LTS version", but there is nodefault:for this input and the action only manages Node whennode-version(ornode-version-file) is provided. Since this PR updates the description, it should accurately document the three states: unset (no Node management unlessnode-version-fileis set), a version (runsvp env use), andoff(runsvp env off).
description: "Node.js version to install via `vp env use`. Defaults to Node.js latest LTS version. Pass `off` to disable."
|
waiting for merge ig |
|
@KTrain5169 Could you try this environment variable? It should be able to disable the Node.js version manager. - uses: voidzero-dev/setup-vp@v1
env:
VP_NODE_MANAGER: "no" |
will check later |
|
@fengmk2 the env variable doesn't seem to work |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (2)
action.yml:25
- The
node-versioninput description still claims it defaults to the latest LTS, but there is nodefault:for this input and the action only runsvp env usewhen a value is provided. This is misleading, especially now thatoffis a supported explicit value. Reword to document the three states: unset (no Node management), version (env use), andoff(env off).
description: "Node.js version to install via `vp env use`. Defaults to Node.js latest LTS version. Pass `off` to disable."
src/index.ts:38
"off"is now a reserved sentinel value for thenode-versioninput, but this logic also triggers whennodeVersioncomes fromnode-version-file. If a version file accidentally containsoff, the action will runvp env off(or silently skip Node setup) instead of failing fast, which can mask a bad version file. Gate thevp env offbranch on the explicitnode-versioninput, and consider throwing ifnode-version-fileresolves to the reserved value.
info(`Setting up Node.js ${nodeVersion} via vp env use...`);
await exec("vp", ["env", "use", nodeVersion]);
} else if (nodeVersion === "off") {
info("Disabling Node.js version management with vp env off...");
await exec("vp", ["env", "off"]);
A request from the Discord channel, this allows people who already use other systems to manage their Node version (such as Flox) to prevent Vite+ from messing with the used Node.js version.
I'm not quite sure if there's anything else to do, from the looks of it, it does seem so, but other pairs of eyes to look over this are appreciated.