Skip to content

chmod: remove duplicate code handling symlinks - #13873

Open
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:chmod_remove_duplicate_code
Open

chmod: remove duplicate code handling symlinks#13873
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:chmod_remove_duplicate_code

Conversation

@cakebaker

Copy link
Copy Markdown
Contributor

This PR is a follow-up to #13842 and removes some duplicate code for handling symlinks.

@cakebaker
cakebaker marked this pull request as draft August 11, 2026 09:21
@cakebaker

Copy link
Copy Markdown
Contributor Author

#13872 should be merged first.

@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 148.93 MB (+320 KB, +0.21%)

Significant per-binary changes:
  install     1.24 MB ->    1.32 MB  (+80 KB, +6.29%)
  mkdir       1.09 MB ->    1.17 MB  (+80 KB, +7.14%)
  mkfifo      1.09 MB ->    1.16 MB  (+76 KB, +6.83%)
  mknod       1.09 MB ->    1.17 MB  (+76 KB, +6.79%)

@oech3

oech3 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Sorry for confliction

@codspeed-hq

codspeed-hq Bot commented Aug 11, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 3.92%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 345 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation du_max_depth_balanced_tree[(6, 4, 10)] 61.8 ms 64.4 ms -4.08%
Simulation du_summarize_balanced_tree[(5, 4, 10)] 16 ms 16.6 ms -3.77%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing cakebaker:chmod_remove_duplicate_code (74cb4f8) with main (33df181)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cakebaker

Copy link
Copy Markdown
Contributor Author

Your PR was first, no need to apologize :)

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)

@cakebaker
cakebaker force-pushed the chmod_remove_duplicate_code branch from b4aa27e to 74cb4f8 Compare August 11, 2026 11:24
@cakebaker
cakebaker marked this pull request as ready for review August 11, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants