chmod: remove duplicate code handling symlinks - #13873
Conversation
|
#13872 should be merged first. |
|
Binary size comparison: |
|
Sorry for confliction |
Merging this PR will degrade performance by 3.92%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | du_max_depth_balanced_tree[(6, 4, 10)] |
61.8 ms | 64.4 ms | -4.08% |
| ❌ | Simulation | du_summarize_balanced_tree[(5, 4, 10)] |
16 ms | 16.6 ms | -3.77% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing cakebaker:chmod_remove_duplicate_code (74cb4f8) with main (33df181)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
Your PR was first, no need to apologize :) |
|
GNU testsuite comparison: |
b4aa27e to
74cb4f8
Compare
This PR is a follow-up to #13842 and removes some duplicate code for handling symlinks.