Skip to content

mktemp: remove the temp file when its name cannot be printed - #13853

Open
sylvestre wants to merge 1 commit into
uutils:mainfrom
sylvestre:mktemp-write-error
Open

mktemp: remove the temp file when its name cannot be printed#13853
sylvestre wants to merge 1 commit into
uutils:mainfrom
sylvestre:mktemp-write-error

Conversation

@sylvestre

Copy link
Copy Markdown
Contributor

Should make test mktemp/write-error.sh pass

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 148.94 MB (+328 KB, +0.22%)

Significant per-binary changes:
  install     1.24 MB ->    1.32 MB  (+80 KB, +6.29%)
  mkdir       1.09 MB ->    1.17 MB  (+80 KB, +7.14%)
  mkfifo      1.09 MB ->    1.16 MB  (+76 KB, +6.83%)
  mknod       1.09 MB ->    1.17 MB  (+76 KB, +6.79%)

@codspeed-hq

codspeed-hq Bot commented Aug 10, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 11.2%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 345 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation df_with_path 573.7 µs 704.4 µs -18.56%
Simulation numfmt_large_numbers_si[10000] 94.7 ms 97.8 ms -3.18%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing sylvestre:mktemp-write-error (6c152ff) with main (822aa83)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/io-errors (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/mktemp/write-error is no longer failing!
Congrats! The gnu test tests/tail/pipe-f2 is no longer failing!
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@cakebaker

Copy link
Copy Markdown
Contributor

clippy is not happy :|

Should make test mktemp/write-error.sh pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants