[pull] master from ruby:master - #1286
Merged
Merged
Conversation
) YJIT's jit_rb_str_concat branches on the two strings' encoding flags and calls a simple rb_str_cat-based append when they match, which skips the coderange and encoding bookkeeping in rb_str_buf_append. Do the same in ZJIT's StringAppend codegen. Since the helper is now shared by both JITs, move it from yjit.c to jit.c and rename it from rb_yjit_str_simple_append to rb_jit_str_simple_append. This recovers most of the gap against YJIT on the str_concat benchmark.
Proposed in https://bugs.ruby-lang.org/issues/22118 Merged in #17353
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )