[pull] master from php:master - #1166
Merged
Merged
Conversation
…23102) Both functions are declared with no parameters in the stub, but neither implementation called ZEND_PARSE_PARAMETERS_NONE(), so extra positional arguments were silently accepted instead of raising ArgumentCountError. Every other zero-arity function of the same SAPI (apache_request_headers(), apache_response_headers(), getallheaders()) already enforces its arity, and so does the litespeed implementation of apache_get_modules(). No stub or arginfo change is needed. Co-authored-by: lacatoire <ext-lacatoire@cenef.fr>
Centralising the logic for {un}locking readonly properties for `clone` and `clone with`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )