fix(webapp): stop the billing limits page timing out under enforcement

[matt-aitken]

Summary

Opening the billing limits page while a spend limit was being enforced could time out with no response for organizations with many preview branches. That is exactly the moment the page matters: it is the only self-serve way to raise or resolve the limit. The page now loads fast regardless of how many environments the organization has.

Root cause and fix

The loader's queued-run count ran one ClickHouse count per billable environment, sequentially, with no timeout, and the environment list included every archived preview branch ever created. Thousands of environments times one round trip each held the response open past the edge timeout.

The count is now a single org-level ClickHouse query filtered on environment type, capped server-side with max_execution_time. If the count fails, the loader falls back to 0 (the page hides the count label at 0) instead of throwing, so the recovery panel stays reachable even when the count errors. The billing-limit bulk-cancel path also stops enumerating archived environments.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 86c7096

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

Billing-limit queued-run counting now uses one organization-level ClickHouse query with a 10-second execution cap. The query counts pending and delayed runs from billable environment types, including archived environments. Counting failures are logged and return zero at the display layer. Integration tests cover queued-run filtering and environment classification. A changelog entry documents the billing limits page timeout fix.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the problem and fix but omits the required issue link, checklist, testing steps, changelog, and screenshots sections.	Add the required template sections, link the closed issue, record testing performed, provide a changelog entry, and mark applicable checklist items.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the primary fix for billing limits page timeouts during enforcement.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/billing-limits-queued-count

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

apps/webapp/test/billingLimitQueuedRuns.test.ts (1)

117-119: 🚀 Performance & Scalability | 🔵 Trivial | 🏗️ Heavy lift

Make the one-query contract executable.

The test name says “with a single query”, but Line 234 checks only the total count. A sequential per-environment implementation can still return 3 and pass. Add a query-count assertion through the Testcontainers-backed ClickHouse path, or rename the test if query multiplicity is not part of the contract.

Based on the PR objective to replace sequential per-environment counts with one organization-level query, keep this behavior covered by a regression test. As per coding guidelines: **/*.{test,spec}.{ts,tsx} tests use Vitest exclusively, never mock dependencies, and use Testcontainers for integration dependencies.

Also applies to: 232-234

Source: Coding guidelines

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1be90ff5-d6c4-4022-a0d3-fb6db54f0c92

📥 Commits

Reviewing files that changed from the base of the PR and between 3d00189 and 86c7096.

📒 Files selected for processing (3)

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts
• apps/webapp/app/v3/services/billingLimit/getBillingLimitQueuedRunCount.server.ts
• apps/webapp/test/billingLimitQueuedRuns.test.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/webapp/app/v3/services/billingLimit/getBillingLimitQueuedRunCount.server.ts

📜 Review details

⏰ Context from checks skipped due to timeout. (5)

• GitHub Check: code-quality / code-quality
• GitHub Check: audit
• GitHub Check: audit
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (actions)

🧰 Additional context used

📓 Path-based instructions (12)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead

**/*.{ts,tsx}: Prefer static imports over dynamic import(); use dynamic imports only for unresolvable circular dependencies, genuine performance code splitting, or conditional runtime loading.
Import Trigger.dev tasks from @trigger.dev/sdk; never use @trigger.dev/sdk/v3 or deprecated client.defineJob.
Add agentcrumbs while writing code using approved namespaces; mark lines with // @Crumbs or blocks with `// `#region` `@crumbs, and strip them before merging.

Files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

{packages/core,apps/webapp}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use zod for validation in packages/core and apps/webapp

Files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

Files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

**/*.{test,spec}.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use vitest for all tests in the Trigger.dev repository

**/*.{test,spec}.{ts,tsx}: Use Vitest exclusively and never mock dependencies; use Testcontainers for integration dependencies.
Place test files next to the source files they test.

Files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)

**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries

Files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

apps/webapp/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

apps/webapp/**/*.{ts,tsx}: Access environment variables through the env export of env.server.ts instead of directly accessing process.env
Use subpath exports from @trigger.dev/core package instead of importing from the root @trigger.dev/core path

Do not reintroduce the removed v1 execution path; RunEngineVersion.V1 branches may only reject or finalize gracefully so v3 clients receive a clean 4xx, never a 5xx.

Files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

apps/webapp/**/*.test.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

Do not import env.server.ts directly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable

Files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

apps/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

For apps, use typecheck for verification and never use build as the correctness check.

Files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

apps/webapp/**/*.{test,spec}.{ts,tsx}

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

Test files must not import app/env.server.ts; pass configuration as options instead.

Files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

apps/webapp/app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

apps/webapp/app/**/*.{ts,tsx}: For dashboard changes, visually verify the running Remix app with Chrome DevTools MCP, using snapshots, screenshots, interaction, and console-message checks as appropriate.
Use useCallback and useMemo only for context provider values, expensive derived data used as a dependency, or stable references required by dependency arrays; do not wrap ordinary event handlers or trivial computations.
Use named constants for sentinel or placeholder values instead of scattering raw string literals across comparisons.

Files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

apps/webapp/app/**/*.ts

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

apps/webapp/app/**/*.ts: Never use request.signal to detect client disconnects. Use getRequestAbortSignal() from app/services/httpAsyncStorage.server.ts, which is wired to Express response close events.
Access environment variables through the env export from app/env.server.ts; never use process.env directly.
Always use Prisma findFirst instead of findUnique.
Always use the $transaction helper from ~/db.server, never call prisma.$transaction or $replica.$transaction directly. Pass isolation levels as strings, use Serializable for correctness-critical read-then-write invariants, and guard possibly undefined helper results when a definite value is required.

Files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

apps/webapp/app/v3/**/*.ts

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

New code must target Run Engine V2 through the singleton in app/v3/runEngine.server.ts; do not reintroduce V1 execution paths. V1 branches may only reject or finalize gracefully with a clean 4xx.

Files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

🧠 Learnings (57)

📓 Common learnings

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4556
File: apps/webapp/app/services/dashboardAgentWatches.server.ts:364-375
Timestamp: 2026-08-11T22:35:29.301Z
Learning: In `apps/webapp/app/services/dashboardAgentWatches.server.ts`, `resolveWatchPlanLimits` currently resolves watcher limits to the unlimited sentinel until cloud ships real plan limits. The non-atomic organization active-watch count and `createWatch` sequence is accepted temporarily because finite watcher quotas are not currently enforced. TRI-12863 tracks an organization-scoped atomic guard and concurrent-create test before finite limits are enabled.

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 2681
File: apps/webapp/app/services/platform.v3.server.ts:258-302
Timestamp: 2025-11-14T16:03:06.917Z
Learning: In `apps/webapp/app/services/platform.v3.server.ts`, the `getDefaultEnvironmentConcurrencyLimit` function intentionally throws an error (rather than falling back to org.maximumConcurrencyLimit) when the billing client returns undefined plan limits. This fail-fast behavior prevents users from receiving more concurrency than their plan entitles them to. The org.maximumConcurrencyLimit fallback is only for self-hosted deployments where no billing client exists.

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 4594
File: apps/webapp/test/billingLimitQueuedRuns.test.ts:0-0
Timestamp: 2026-08-12T19:02:29.690Z
Learning: In `apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts`, `getBillableEnvironmentsForBillingLimit` must include archived billable environments. Archiving does not cancel their executing runs, so spend-limit enforcement must still find those environments. The filtering must exclude non-billable environment types such as `DEVELOPMENT`, not environments with `archivedAt` set.

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4516
File: apps/webapp/app/services/dashboardAgentQuota.server.ts:36-89
Timestamp: 2026-08-12T08:49:18.799Z
Learning: For dashboard agent message quotas in `apps/webapp/app/services/dashboardAgentQuota.server.ts`, production currently resolves to the `UNLIMITED_AGENT_MESSAGES` sentinel because cloud billing does not yet provide a finite `agentMessages` limit. The check-then-increment race is accepted during this fail-open rollout. TRI-12863 P0 will introduce finite limits and must implement atomic, idempotent quota reservation and settlement with concurrent-send and redelivery coverage.

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 2264
File: apps/webapp/app/services/runsRepository.server.ts:172-174
Timestamp: 2025-07-12T18:06:04.133Z
Learning: In apps/webapp/app/services/runsRepository.server.ts, the in-memory status filtering after fetching runs from Prisma is intentionally used as a workaround for ClickHouse data delays. This approach is acceptable because the result set is limited to a maximum of 100 runs due to pagination, making the performance impact negligible.

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4552
File: apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.dashboard-agent.ts:158-165
Timestamp: 2026-08-11T10:53:21.099Z
Learning: For the dashboard agent message quota rollout, `apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.dashboard-agent.ts` intentionally fails open when the cloud `agentMessages` plan limit is unavailable. During this transition, `apps/webapp/app/components/dashboard-agent/useAgentMessageQuota.ts` applies the client-side free-plan upgrade nudge because it can identify a cloud free plan. Server-provided quota-limit propagation is planned in TRI-12863.

📚 Learning: 2026-07-27T15:07:14.579Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 4397
File: apps/webapp/test/batchStreamGrants.test.ts:0-0
Timestamp: 2026-07-27T15:07:14.579Z
Learning: In `triggerdotdev/trigger.dev`, `apps/webapp/test/authorizationRateLimitMiddleware.test.ts` remains skipped because correcting its plaintext Redis fixture setup (`tlsDisabled`) exposed a timing-sensitive sliding-window test based on real 10-second windows. The new authorization-rate-limit bypass coverage instead lives in the unskipped, deterministic `apps/webapp/test/authorizationRateLimitMiddlewareBypass.test.ts`. Do not flag the legacy suite's continued skip as missing coverage for the bypass behavior.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-03-03T13:07:33.177Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3166
File: internal-packages/run-engine/src/batch-queue/tests/index.test.ts:711-713
Timestamp: 2026-03-03T13:07:33.177Z
Learning: In `internal-packages/run-engine/src/batch-queue/tests/index.test.ts`, test assertions for rate limiter stubs can use `toBeGreaterThanOrEqual` rather than exact equality (`toBe`) because the consumer loop may call the rate limiter during empty pops in addition to actual item processing, and this over-calling is acceptable in integration tests.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-04-15T15:39:31.575Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2026-04-15T15:39:31.575Z
Learning: Applies to apps/webapp/**/*.test.{ts,tsx} : Do not import `env.server.ts` directly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-07-18T18:31:37.633Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 4285
File: internal-packages/run-store/src/runOpsStore.presentersWaitpointReadView.replicaLag.test.ts:24-65
Timestamp: 2026-07-18T18:31:37.633Z
Learning: In `triggerdotdev/trigger.dev`’s `internal-packages/run-store/src/runOpsStore.presentersWaitpointReadView.replicaLag.test.ts`, retain the local real-Testcontainers Prisma proxy rather than requiring the shared `laggingReplica` helper: the test must simulate lag for `waitpointTag` reads and for `findWaitpointConnectedRunIds`, which uses `$queryRaw`. The shared primitive intercepts configured Prisma models but not raw queries, so replacing the proxy would allow the live raw join to observe primary data and invalidate the replica-lag guard. The related taskRun-only tests (`runOpsStore.realtimeServicesReadView.replicaLag.test.ts`, `runOpsStore.replayReadAfterWrite.replicaLag.test.ts`, and `runOpsStore.resolveRunForMutationReplicaLag.test.ts`) can use the shared primitive with `{ model: "taskRun", mode: "missing" }`.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-07-30T18:43:56.874Z

Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4426
File: apps/webapp/test/memberDevEnvironments.server.test.ts:124-125
Timestamp: 2026-07-30T18:43:56.874Z
Learning: In the `apps/webapp` test suite (`apps/webapp/test/**`), respect the established test harness in `apps/webapp/test/setup.ts`: it loads `.env` and provides default values for required environment variables so that transitive imports (e.g., `~/env.server`) work without production-style wiring.

During code review, do not require dependency injection/refactoring solely to avoid this existing import path. Only introduce configuration injection if it delivers production-level value (for example, a more general `createEnvironment` abstraction that improves runtime behavior beyond test setup).

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-07-15T18:37:08.044Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: apps/webapp/CLAUDE.md:0-0
Timestamp: 2026-07-15T18:37:08.044Z
Learning: Applies to apps/webapp/**/*.{test,spec}.{ts,tsx} : Test files must not import `app/env.server.ts`; pass configuration as options instead.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-07-26T00:55:21.349Z

Learnt from: 1stvamp
Repo: triggerdotdev/trigger.dev PR: 4367
File: internal-packages/run-engine/design/plans/2026-07-23-ck-virtual-time-scheduling-plan.md:678-685
Timestamp: 2026-07-26T00:55:21.349Z
Learning: For CK virtual-time scheduling in `internal-packages/run-engine/src/run-queue/tests/ckVtimeConcurrency.test.ts`, the Redis operation-count assertion is intentionally a regression guard for a measured scenario rather than a formal worst-case complexity proof. Pass-1 and pass-2 `tryServe` attempts are bounded by their scan windows; the resulting window-versus-attempt overhead limitation is documented in `internal-packages/run-engine/src/run-queue/CK_VTIME_KNOWN_LIMITATIONS.md`.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-04-07T14:12:18.946Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3331
File: apps/webapp/test/engine/batchPayloads.test.ts:5-24
Timestamp: 2026-04-07T14:12:18.946Z
Learning: In `apps/webapp/test/engine/batchPayloads.test.ts`, using `vi.mock` for `~/v3/objectStore.server` (stubbing `hasObjectStoreClient` and `uploadPacketToObjectStore`), `~/env.server` (overriding offload thresholds), and `~/v3/tracer.server` (stubbing `startActiveSpan`) is intentional and acceptable. Simulating controlled transient upload failures (e.g., fail N times then succeed) to verify `p-retry` behavior cannot be reproduced with real services or testcontainers. This file is an explicit exception to the repo's general no-mocks policy.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-08-11T22:35:29.301Z

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4556
File: apps/webapp/app/services/dashboardAgentWatches.server.ts:364-375
Timestamp: 2026-08-11T22:35:29.301Z
Learning: In `apps/webapp/app/services/dashboardAgentWatches.server.ts`, `resolveWatchPlanLimits` currently resolves watcher limits to the unlimited sentinel until cloud ships real plan limits. The non-atomic organization active-watch count and `createWatch` sequence is accepted temporarily because finite watcher quotas are not currently enforced. TRI-12863 tracks an organization-scoped atomic guard and concurrent-create test before finite limits are enabled.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-04-16T13:45:22.317Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3368
File: apps/webapp/test/engine/taskIdentifierRegistry.test.ts:3-19
Timestamp: 2026-04-16T13:45:22.317Z
Learning: In `apps/webapp/test/engine/taskIdentifierRegistry.test.ts`, the `vi.mock` calls for `~/services/taskIdentifierCache.server` (stubbing `getTaskIdentifiersFromCache` and `populateTaskIdentifierCache`), `~/models/task.server` (stubbing `getAllTaskIdentifiers`), and `~/db.server` (stubbing `prisma` and `$replica`) are intentional. The suite uses real Postgres via testcontainers for all `TaskIdentifier` DB operations, but isolates the Redis cache layer and legacy query fallback as separate concerns not exercised in this test file. Do not flag these mocks as violations of the no-mocks policy in future reviews.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-05-01T15:45:09.326Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3499
File: apps/webapp/test/auth-cross-cutting.e2e.full.test.ts:206-213
Timestamp: 2026-05-01T15:45:09.326Z
Learning: In `apps/webapp/test/auth-cross-cutting.e2e.full.test.ts`, the cross-environment JWT isolation test intentionally asserts `expect([401, 404]).toContain(res.status)` rather than a strict `expect(res.status).toBe(404)`. The dual-status assertion is deliberate: both 401 (auth rejected) and 404 (resource not found in the resolved env) prove the negative — that the JWT cannot access a resource scoped to a different environment. The loose assertion is kept so a planned change to the auth response code (e.g. returning 404 instead of 401 for cross-env mismatch) does not immediately break this test. The control case that proves the JWT itself is valid is covered by other tests in the same describe block.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-06-06T09:22:01.985Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3851
File: apps/webapp/app/v3/taskEventStore.server.ts:311-366
Timestamp: 2026-06-06T09:22:01.985Z
Learning: In `apps/webapp/app/v3/taskEventStore.server.ts` (triggerdotdev/trigger.dev), `TaskEventStore.streamDetailedTraceEvents` (and all sibling Postgres query methods: `findTraceEvents`, `findDetailedTraceEvents`) intentionally filter only by `traceId`, NOT by `environmentId`. This is consistent across the entire Postgres event-query surface. Rationale: (1) OTel trace IDs are globally-unique 16-byte values so cross-environment row mixing is not possible in practice, and (2) the download route always authorizes the run by org membership before calling these methods. Do NOT flag the absence of `environmentId` in these Postgres trace queries. The ClickHouse path scopes by `environment_id` solely because it is the partition/index key, not because the Postgres path has a correctness gap.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-08-08T17:53:11.238Z

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4525
File: apps/webapp/test/dashboardAgentWatchErrorFingerprint.test.ts:0-0
Timestamp: 2026-08-08T17:53:11.238Z
Learning: In `apps/webapp/test/setup.ts`, environment defaults such as `SESSION_SECRET` use `??=`. This preserves values supplied by the shell or CI. During review, do not treat this setup behavior as an unconditional test-environment override.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-07-18T18:17:16.266Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 4285
File: internal-packages/run-store/src/runOpsStore.routesSpanTraceReadView.replicaLag.test.ts:50-81
Timestamp: 2026-07-18T18:17:16.266Z
Learning: In triggerdotdev/trigger.dev replica-lag integration tests, some sibling test files intentionally use shape-scoped local Prisma proxy wrappers over real Postgres testcontainers to simulate only the read operations exercised by that site. These are not dependency mocks or Testcontainers-policy violations. Consolidation onto the shared `laggingReplica` primitive may be deliberately deferred to a follow-up to avoid infrastructure churn before merge; treat this as a consistency/maintenance concern rather than a merge-blocking functional defect.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-07-26T20:37:56.220Z

Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 4379
File: apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.vercel.tsx:0-0
Timestamp: 2026-07-26T20:37:56.220Z
Learning: In `apps/webapp/app/components/integrations/VercelBuildSettings.tsx` and the Vercel onboarding flow, `atomicBuilds` is intentionally UI-constrained to `["prod"]` or `[]`; although its schema accepts `EnvSlug` values, supported UI paths never write `"stg"`. When clearing a Vercel Staging environment mapping in `apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.vercel.tsx`, only `pullEnvVarsBeforeBuild` and `discoverEnvVars` need to have `"stg"` removed.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-07-26T20:37:50.445Z

Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 4379
File: apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.github.tsx:977-1014
Timestamp: 2026-07-26T20:37:50.445Z
Learning: In `apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.github.tsx`, `ConnectedGitHubRepoForm` must preserve `previewDeploymentsEnabled` in form submissions when Preview is plan-gated: the Upgrade-only branch renders a hidden `previewDeploymentsEnabled=on` input whenever the persisted connected repository setting is enabled. This prevents the Zod missing-value transform from silently clearing the setting during unrelated Git settings saves.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-03-22T13:26:12.060Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-03-22T19:24:14.403Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-05-18T08:21:27.694Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-05-18T08:21:27.694Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-06-13T19:53:13.759Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-06-17T17:13:49.929Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-06-23T13:04:21.413Z

Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-05-07T12:25:18.271Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-05-28T20:02:10.647Z

Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-08-08T12:49:17.489Z

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4525
File: apps/webapp/test/dashboardAgentWatchAlertOwnerScope.test.ts:101-109
Timestamp: 2026-08-08T12:49:17.489Z
Learning: In apps/webapp/test, every test suite that creates a client with createDashboardAgentDb(connectionUri, ...) must close the DashboardAgentDbClient in afterEach. Although postgresTest drops cloned databases with WITH (FORCE), it does not clean up client-side postgres-js pool sockets or idle timers, so explicitly closing the client prevents resource leaks and test interference.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-05-12T21:04:05.815Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.

Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.

Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-06-25T18:21:51.905Z

Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-07-03T17:10:21.498Z

Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-05-18T14:40:02.173Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-06-04T18:16:35.386Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-06-09T17:58:04.699Z

Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts
• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-06-16T09:19:47.637Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.

Applied to files:

• apps/webapp/test/billingLimitQueuedRuns.test.ts

📚 Learning: 2026-04-17T13:56:37.517Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3333
File: apps/webapp/app/services/queryService.server.ts:278-279
Timestamp: 2026-04-17T13:56:37.517Z
Learning: In `apps/webapp/app/services/queryService.server.ts`, the `queryConcurrencyLimiter` is intentionally keyed by `projectId` (not `organizationId`), even though the ClickHouse client is organization-scoped. Concurrency control is deliberately enforced at the project level. Do not flag the `projectId` key in `queryConcurrencyLimiter.acquire`/`release` as a bug or suggest changing it to `organizationId`.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-08-12T08:49:18.799Z

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4516
File: apps/webapp/app/services/dashboardAgentQuota.server.ts:36-89
Timestamp: 2026-08-12T08:49:18.799Z
Learning: For dashboard agent message quotas in `apps/webapp/app/services/dashboardAgentQuota.server.ts`, production currently resolves to the `UNLIMITED_AGENT_MESSAGES` sentinel because cloud billing does not yet provide a finite `agentMessages` limit. The check-then-increment race is accepted during this fail-open rollout. TRI-12863 P0 will introduce finite limits and must implement atomic, idempotent quota reservation and settlement with concurrent-send and redelivery coverage.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2025-11-14T16:03:06.917Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 2681
File: apps/webapp/app/services/platform.v3.server.ts:258-302
Timestamp: 2025-11-14T16:03:06.917Z
Learning: In `apps/webapp/app/services/platform.v3.server.ts`, the `getDefaultEnvironmentConcurrencyLimit` function intentionally throws an error (rather than falling back to org.maximumConcurrencyLimit) when the billing client returns undefined plan limits. This fail-fast behavior prevents users from receiving more concurrency than their plan entitles them to. The org.maximumConcurrencyLimit fallback is only for self-hosted deployments where no billing client exists.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-07-15T18:37:08.044Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: apps/webapp/CLAUDE.md:0-0
Timestamp: 2026-07-15T18:37:08.044Z
Learning: Applies to apps/webapp/app/v3/services/{triggerTask,batchTriggerV3}.server.ts : Do not add database queries to `triggerTask.server.ts` or `batchTriggerV3.server.ts`; reuse the existing queue query and preserve the two-stage trigger-time/dequeue-time resolution pattern. Add task defaults to the existing `select` clause or resolve them at dequeue time.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-08-11T10:53:21.099Z

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4552
File: apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.dashboard-agent.ts:158-165
Timestamp: 2026-08-11T10:53:21.099Z
Learning: For the dashboard agent message quota rollout, `apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.dashboard-agent.ts` intentionally fails open when the cloud `agentMessages` plan limit is unavailable. During this transition, `apps/webapp/app/components/dashboard-agent/useAgentMessageQuota.ts` applies the client-side free-plan upgrade nudge because it can identify a cloud free plan. Server-provided quota-limit propagation is planned in TRI-12863.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2025-07-12T18:06:04.133Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 2264
File: apps/webapp/app/services/runsRepository.server.ts:172-174
Timestamp: 2025-07-12T18:06:04.133Z
Learning: In apps/webapp/app/services/runsRepository.server.ts, the in-memory status filtering after fetching runs from Prisma is intentionally used as a workaround for ClickHouse data delays. This approach is acceptable because the result set is limited to a maximum of 100 runs due to pagination, making the performance impact negligible.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2025-06-14T08:07:46.625Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 2175
File: apps/webapp/app/services/environmentMetricsRepository.server.ts:202-207
Timestamp: 2025-06-14T08:07:46.625Z
Learning: In apps/webapp/app/services/environmentMetricsRepository.server.ts, the ClickHouse methods (getTaskActivity, getCurrentRunningStats, getAverageDurations) intentionally do not filter by the `tasks` parameter at the ClickHouse level, even though the tasks parameter is accepted by the public methods. This is done on purpose as there is not much benefit from adding that filtering at the ClickHouse layer.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-02-10T16:18:48.654Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 2980
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx:512-515
Timestamp: 2026-02-10T16:18:48.654Z
Learning: In apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx, environment.queueSizeLimit is a per-queue maximum that is configured at the environment level, not a shared limit across all queues. Each queue can have up to environment.queueSizeLimit items queued independently.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-05-22T11:51:03.748Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3333
File: apps/webapp/app/runEngine/services/triggerFailedTask.server.ts:76-80
Timestamp: 2026-05-22T11:51:03.748Z
Learning: In the triggerdotdev/trigger.dev codebase, ClickHouse is the source of truth for most reads (run lists, span detail, logs) — there is no Postgres fallback for those paths. Reassigning an org from one ClickHouse cluster to another therefore requires migrating that org's existing ClickHouse data first; it cannot be done by simply updating the OrganizationDataStore entry. The work to design and implement that migration is tracked under Linear issue TRI-9659 (sub-issue of TRI-7994). During the initial rollout of org-scoped ClickHouse (PR `#3333`), no production org has an override configured, so this limitation is not yet reachable in production.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-07-02T19:14:58.851Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 4124
File: internal-packages/database/prisma/migrations/20260629120000_drop_run_ops_control_plane_foreign_keys/migration.sql:1-26
Timestamp: 2026-07-02T19:14:58.851Z
Learning: Repo triggerdotdev/trigger.dev: In the run-ops DB split (schema.prisma / internal-packages/database/prisma/migrations), the intentional pattern is to keep Prisma `relation` declarations on models like TaskRun, Waitpoint, TaskRunWaitpoint, TaskRunCheckpoint, TaskRunAttempt, TaskRunTag, and WaitpointTag even after dropping the corresponding DB-level foreign key constraints via migration (e.g., migrations under 20260629120000_drop_run_ops_control_plane_foreign_keys and related). This is not schema drift: on the dedicated run-ops DB, `internal-packages/run-store/src/PostgresRunStore.ts` uses `stripDedicatedRelations` to strip these relation keys from Prisma select/include before querying, then `#hydrateDedicatedRelations` re-populates them from scalar columns or join lookups (e.g., hydrateAssociatedWaitpoint, hydrateBlockingTaskRuns). Do not flag missing schema updates to remove `relation` fields when FK constraints are dropped in this codebase's run-ops split migrations.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-05-15T08:05:57.683Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3625
File: apps/webapp/app/services/taskMetadataCache.server.ts:270-291
Timestamp: 2026-05-15T08:05:57.683Z
Learning: In the triggerdotdev/trigger.dev codebase, `populateByCurrentWorker()` in `apps/webapp/app/services/taskMetadataCache.server.ts` intentionally logs and swallows Redis errors rather than rethrowing. The design rationale: rethrowing would propagate into `ChangeCurrentDeploymentService.call` and break deploy promotion when Redis is briefly unavailable; the 24h `TASK_META_CACHE_CURRENT_ENV_TTL_SECONDS` TTL acts as the self-healing window for cache drift, and next-promotion overwrites the env key sooner in practice. A compensating DEL on failure is also not a win because if Redis is unreachable the DEL fails identically, and Lua scripts are atomic so a partial write is impossible. Do not flag this log+swallow pattern as a bug in future reviews.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-05-12T06:43:12.346Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3558
File: internal-packages/run-engine/src/run-queue/index.ts:420-424
Timestamp: 2026-05-12T06:43:12.346Z
Learning: In the triggerdotdev/trigger.dev codebase (`internal-packages/run-engine/src/run-queue/index.ts`), the established convention in `RunQueue` read-path methods (e.g., `lengthOfQueue`, `lengthOfQueues`, `currentConcurrencyOfQueues`) is to **fail open** on transient Redis pipeline errors: pipeline result errors (`baseErr`, `ctrErr`, etc.) are coerced to `0` rather than surfaced or re-thrown. This is intentional — the project treats Redis command errors the same as missing keys for these counter reads. Do not flag this pattern as a bug or suggest throwing/propagating these errors in future reviews.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-06-01T15:01:35.175Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3756
File: apps/webapp/app/v3/services/resetIdempotencyKey.server.ts:65-94
Timestamp: 2026-06-01T15:01:35.175Z
Learning: In `apps/webapp/app/v3/services/resetIdempotencyKey.server.ts` (triggerdotdev/trigger.dev), a transient `buffer.resetIdempotency()` failure when `pgCount > 0` does NOT warrant a 503 and should return success. The mollifier `ack` and `fail` Lua scripts always DEL the idempotency lookup key as part of the run's natural lifecycle (drain→ack or terminal→fail or cancel-bifurcation), so stale buffered idempotency lookups converge automatically without caller retries. Only when `pgCount === 0 && bufferResetFailed` is a 503 appropriate, because then the run's existence is genuinely unobservable (the buffer outage hides a potentially matching buffered run). The test "returns success when PG cleared >=1 run, even if the buffer reset throws" documents this contract explicitly.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-07-27T15:07:29.887Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 4397
File: internal-packages/run-engine/src/engine/systems/batchSystem.ts:81-96
Timestamp: 2026-07-27T15:07:29.887Z
Learning: In `internal-packages/run-engine/src/engine/systems/batchSystem.ts`, `BatchSystem.#tryCompleteBatch` must guard its terminal completion update by excluding terminal statuses (`status: { notIn: ["ABORTED", "COMPLETED"] }`), rather than allow-listing `PENDING` or `PROCESSING`. Sealing transitions a batch to `PROCESSING`, and partial run-creation failures may use other legitimate non-terminal states; a `PENDING`-only guard leaves batchTriggerAndWait parent waitpoints unresolved.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-03-03T13:08:03.862Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3166
File: packages/redis-worker/src/fair-queue/index.ts:1114-1121
Timestamp: 2026-03-03T13:08:03.862Z
Learning: In packages/redis-worker/src/fair-queue/index.ts, it's acceptable for the worker queue depth cap check to allow overshooting by up to batchClaimSize messages per iteration, as the next iteration will recheck and prevent sustained growth beyond the limit.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-05-12T21:04:09.475Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: packages/core/src/v3/schemas/api.ts:1498-1503
Timestamp: 2026-05-12T21:04:09.475Z
Learning: In triggerdotdev/trigger.dev, `TriggerOptions.maxDuration` (in `packages/core/src/v3/schemas/api.ts`, used in `TriggerTaskRequestBody` around line 206 and `BatchTriggerTaskItem` around line 259) has NO minimum value — it is simply `z.number().optional()`. Do not flag `SessionTriggerConfig.maxDuration` (which uses `z.number().int().positive()`) for not matching a "5-second floor" because no such floor exists in `TriggerOptions.maxDuration`.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-06-10T15:16:48.748Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3889
File: internal-packages/run-engine/src/engine/index.ts:0-0
Timestamp: 2026-06-10T15:16:48.748Z
Learning: In `internal-packages/run-engine/src/engine/index.ts` (RunEngine constructor), `readReplicaSnapshotsSinceRetryDelay.maxMs <= 0` is the documented sentinel to *disable* the jittered replica retry in `getSnapshotsSince`. When normalizing these bounds, do NOT clamp with `Math.max(minMs, maxMs)` because that would silently turn `maxMs=0` (disabled) into `maxMs=minMs` (enabled). Instead, preserve `maxMs` as-is and only clamp `minMs` into `[0, maxMs]` when `maxMs > 0`:
```typescript
const retryMinMs = Math.max(0, retryDelay.minMs);
this.snapshotsSinceReplicaRetryDelay = {
  minMs: retryDelay.maxMs > 0 ? Math.min(retryMinMs, retryDelay.maxMs) : retryMinMs,
  maxMs: retryDelay.maxMs,
};
```

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-08-12T19:02:29.690Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 4594
File: apps/webapp/test/billingLimitQueuedRuns.test.ts:0-0
Timestamp: 2026-08-12T19:02:29.690Z
Learning: In `apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts`, `getBillableEnvironmentsForBillingLimit` must include archived billable environments. Archiving does not cancel their executing runs, so spend-limit enforcement must still find those environments. The filtering must exclude non-billable environment types such as `DEVELOPMENT`, not environments with `archivedAt` set.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-03-10T17:56:20.938Z

Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3201
File: apps/webapp/app/v3/services/setSeatsAddOn.server.ts:25-29
Timestamp: 2026-03-10T17:56:20.938Z
Learning: Do not implement local userId-to-organizationId authorization checks inside org-scoped service classes (e.g., SetSeatsAddOnService, SetBranchesAddOnService) in the web app. Rely on route-layer authentication (requireUserId(request)) and org membership enforcement via the _app.orgs.$organizationSlug layout route. Any userId/organizationId that reaches these services from org-scoped routes has already been validated. Apply this pattern across all org-scoped services to avoid redundant auth checks and maintain consistency.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-03-29T19:16:28.864Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-06-09T16:27:26.195Z

Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-05-05T09:38:02.512Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

📚 Learning: 2026-05-14T08:21:07.614Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3614
File: apps/webapp/app/v3/mollifier/mollifierGate.server.ts:48-52
Timestamp: 2026-05-14T08:21:07.614Z
Learning: When using Trigger.dev v3 feature flags in the webapp, prefer the existing per-org gating mechanism supported by `flag()` via the `overrides` argument. Pass `Organization.featureFlags` (from `environment.organization.featureFlags`) as the `overrides` value; overrides must take precedence over the global `featureFlag` row. Do not require schema changes or add an `orgId` field to `FlagsOptions` for per-org gating—use the overrides pattern consistently (e.g., in gate flows like `resolveOrgFlag` and any server code that threads `environment.organization.featureFlags` into the gate call).

Applied to files:

• apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts

🔇 Additional comments (4)

apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts (3)

18-22: LGTM!

---

92-110: LGTM!

Also applies to: 117-117

---

111-115: 🩺 Stability & Availability

No change is required. The only production caller catches the rejection and returns 0; the other usage is a test.

			> Likely an incorrect or invalid review comment.

apps/webapp/test/billingLimitQueuedRuns.test.ts (1)

5-9: LGTM!

Also applies to: 238-299