Fix/ppi widget accessibility - #508
Open
ReneeSleepy wants to merge 1492 commits into
Open
Conversation
* refactor: format codebase and implement lint checks * ci: fail lint workflow on warnings * chore: remove rule ignore * refactor: remove empty lifecycle methods * chore: revert empty method * refactor: switch to modern lifecycle methods * refactor: switch to records * refactor: consistent type assertions * refactor: consistent type definitions * refactor: remove empty block statements * chore: re-enable no useless escape rule * chore: reenable no misleading character class rule * chore: no wrapper object types * chore: fix no constant binary expression * refactor: remove this alias * refactor: no unused expressions * refactor: prefer const * chore: no var rule * refactor: no unused vars * refactor: no inline templates * refactor: no inline styles * refactor: enforce modern angular control flow * refactor: no empty functions * chore: update pull request template * refactor: consistent generic constructors * refactor: no empty object types * chore: remove todo * refactor: remove use of any * refactor: enforce alt text * chore: enforce no empty content * chore: add todo * chore: add recommended rules * refactor: sort tailwind classes
* chore: init communication system editor * feat: add core communications logic * refactor: improve ui layout * refactor: preview email * refactor: ability to edit conditions and actions * refactor: clean up ui layout * feat: enable set execution * refactor: improve layout * refactor: improve ui layout * feat: add confirmation modals to execute rule and set * feat: add scheduling ui * chore: remove duplicate header * fix: ensure students are loaded * refactor: move buttons * fix: disable horizontal scrolling * refactor: improve ui * chore: revert full width change * chore: improve current week ui * chore: format * feat: add spec con days condition * feat: add task comment action * chore: fix layout * chore: remove unnecessary shortcuts * refactor: use server side current week number * refactor: modularise components * chore: fix styling
feat: task list filters and sorting
feat: rediscuss status
…tes to PPI widget
feat: add peer progress indicator (ppi) data contract, mock service, …
…s' into fix/ppi-widget-accessibility
… into feature/PPI-F03-ppi-widget-states
…ppi-widget-states feat: add safe loading, hidden, unavailable and error states to task-sheet PPI widget (PPI-F03)
… into fix/ppi-widget-accessibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR applies targeted accessibility improvements to the task-sheet PPI widget.
The changes:
Add meaningful accessible text for peer submission progress.
Ensure the comparison is not communicated by colour alone.
Hide decorative icons from screen readers.
Keep the changes focused on the existing PPI widget.
Fixes # (issue)
Type of change
How Has This Been Tested?
I ran the Angular test suite using:
npm.cmd test -- --watch=falseThe results were:
The Angular application also compiled successfully.
Manual browser verification could not be completed because the local OnTrack login page currently shows "Temporarily unavailable".
Testing Checklist:
Checklist: