Add missing require for payload_codec in data_converter - #524
Merged
chris-olszewski merged 1 commit intoAug 13, 2026
Merged
Conversation
DataConverter accepts a payload_codec parameter but did not require the PayloadCodec class. Users doing `require 'temporalio/converters'` would get DataConverter without PayloadCodec being loaded. Fixes temporalio#333
chris-olszewski
added
the
skip-changelog
chris-olszewski
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require 'temporalio/converters/payload_codec'todata_converter.rbDataConverteraccepts apayload_codec:parameter but thePayloadCodecclass was not required, so users doingrequire 'temporalio/converters'would getDataConverterwithoutPayloadCodecbeing loadedTest plan
require 'temporalio/converters'now loadsPayloadCodecalongsidePayloadConverterandFailureConverterFixes #333