Remove experimental markers from Worker Deployment RPCs - #850
Open
xepozz wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccf5c5d958
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
xepozz
force-pushed
the
chore/remove-experimental-markers-worker-deployment
branch
from
August 11, 2026 12:23
ccf5c5d to
eb803d3
Compare
Sushisource
approved these changes
Aug 11, 2026
Shivs11
reviewed
Aug 12, 2026
| } | ||
|
|
||
| // Validates the compute config without attaching it to a Worker Deployment Version. | ||
| // Experimental. This API might significantly change or be removed in a future release. |
Member
There was a problem hiding this comment.
this is still an experimental API
| } | ||
|
|
||
| // Updates the compute config attached to a Worker Deployment Version. | ||
| // Experimental. This API might significantly change or be removed in a future release. |
Member
There was a problem hiding this comment.
this is still an experimental API since the ServerLess workers feature is still in public-preview: https://docs.temporal.io/serverless-workers (This feature uses this API)
| } | ||
|
|
||
| // Creates a new Worker Deployment Version. | ||
| // |
| } | ||
|
|
||
| // Creates a new Worker Deployment. | ||
| // |
xepozz
force-pushed
the
chore/remove-experimental-markers-worker-deployment
branch
from
August 13, 2026 07:53
eb803d3 to
66a0b31
Compare
xepozz
force-pushed
the
chore/remove-experimental-markers-worker-deployment
branch
from
August 13, 2026 07:58
66a0b31 to
45a8c58
Compare
Author
|
@Shivs11 fixed, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Drop experimental tags
Why?
It's not experimental anymore.
Also PHP SDK uses this api files to generate PHP classes and every time it adds
@experimentaltags which was removed several months ago temporalio/sdk-php@3ca71a5Breaking changes
Server PR