Use fmf for result filtering - #3
Merged
Merged
Conversation
LecrisUT
approved these changes
Aug 10, 2026
LecrisUT
left a comment
LecrisUT
left a comment
Member
There was a problem hiding this comment.
Just some random nitpicks, otherwise looks fine to me
LecrisUT
reviewed
Aug 11, 2026
There was a problem hiding this comment.
Manual test results
| Scenario | Result |
|---|---|
| Default filter | Kept /tests/beta (fail) and /tests/gamma (error) only |
result: pass |
Kept pass tests |
name: .*/smoke.* |
Kept /tests/smoke/basic |
result: fail | name: .*/smoke.* |
OR worked |
result: -pass & result: -skip |
Negation worked (fail/error/warn) |
defect: none & result: fail |
Worked for local results (defect: None → matches none case-insensitively) |
| No matches | Exit 3 + warnings |
Invalid key boguskey: x |
Raises FilterExpressionError (but see below) |
--run-workdir relative results path |
OK |
Real run-016 (fail) / run-006 (pass) |
Default vs result: pass behaved correctly |
Assisted-by: Composer
Edit: I removed the AI complaints that I am not concerned about. Manual run using --use-reportportal works as expected.
|
Apologies, I asked AI to review, and it decided to post before I could review its review 🙁 |
tcornell-bus
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded result filters with a single fmf expression supporting
name,result, anddefect.Assisted-by: Cursor