fix(mcp): forward configured OAuth scopes during login - #3855
Open
kriptoburak wants to merge 1 commit into
Open
Conversation
Co-Authored-By: ForgeCode <noreply@forgecode.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
forge mcp loginalways passed an empty scope list to the OAuth client. This ignoredoauth.scopesfrom.mcp.json. Scoped servers could then issue insufficient tokens or reject the flow.The change keeps empty scopes for metadata discovery. It forwards explicit scopes when users configure them. The Xquik example uses its published
mcp:toolsscope for authenticated X (Twitter) search and automation.Addresses #3339.
Verification
cargo test -p forge_domain mcp::tests -- --nocapturecargo check -p forge_maincargo test -p forge_main --no-runcargo clippy -p forge_main --all-targets --all-features -- -D warningsrustfmt --edition 2024 --checkon all changed Rust filesjqCo-Authored-By: ForgeCode noreply@forgecode.dev