Fix #436: add --description/-d to publish - #448
Open
jacalata wants to merge 1 commit into
Open
Conversation
tabcmd Classic accepts --description/-d when publishing to set the workbook or data source description. tabcmd 2 was missing the flag, so users had to publish and then run a separate update to set the description. Add --description/-d to set_publish_args and set it on the WorkbookItem or DatasourceItem before calling server.workbooks.publish or server.datasources.publish. TSC's _generate_xml already includes description in the publish request body when the attribute is set. Fixes #436.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #436.
Motivation
tabcmd Classic accepts
--description/-donpublishto set theworkbook or data source description at publish time. tabcmd 2 was
missing the flag, forcing users to do a follow-up REST update to set
the description.
Behavior change
For users:
--description/-daccepted onpublish. Sets it onthe
WorkbookItemorDatasourceItembefore publish; TSC's_generate_xmlalready emitsdescriptionin the publish request bodywhen set.
Test plan
tests/parsers/test_parser_publish.py— 3 new tests:--description "...", short-d "...", flag-optionaltest_parser_publish*.pysuites: 17 passed, 1 skipped🤖 Generated with Claude Code