Skip to content

Fix CONTRIBUTORS.md link in README - #1831

Open
ZayanKhan-12 wants to merge 1 commit into
tableau:developmentfrom
ZayanKhan-12:fix/readme-contributors-link
Open

Fix CONTRIBUTORS.md link in README#1831
ZayanKhan-12 wants to merge 1 commit into
tableau:developmentfrom
ZayanKhan-12:fix/readme-contributors-link

Conversation

@ZayanKhan-12

Copy link
Copy Markdown

The README says "A list of all our contributors to date is in [CONTRIBUTORS.md]." — a reference-style link with no matching definition anywhere in the file, so GitHub renders it as literal bracketed text rather than a link. This makes it an inline link to CONTRIBUTORS.md, which exists at the repository root.

Verification: pip install -e ".[test]" + python -m pytest test pass locally (866 passed, 1 skipped; Python 3.14, macOS arm64).

Prepared with AI assistance (Claude); the missing definition and the target file's existence were both verified.

[CONTRIBUTORS.md] has no matching link definition, so it renders as
literal bracketed text instead of a link. Make it an inline link to
the file, which exists at the repository root.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jacalata

Copy link
Copy Markdown
Contributor

Please update this so it will merge just the file you changed, targeting the development branch.

@jacalata
jacalata changed the base branch from master to development August 6, 2026 21:21
@salesforce-cla

salesforce-cla Bot commented Aug 6, 2026

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @zk-khan to sign the Salesforce Inc. Contributor License Agreement.

@jacalata

jacalata commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Heads up on the CLA check flip — it looks like the commit has a Co-authored-by: Claude Fable 5 noreply@anthropic.com trailer, which Salesforce's CLA bot now reads as a second author needing a signature. Since noreply@anthropic.com can't sign a CLA, the check fails.

The AI-assistance disclosure in the PR body is great to have and totally welcome. It's specifically the Co-authored-by: git trailer that trips the bot.

To unblock:

on your local branch

git commit --amend

remove the "Co-authored-by: Claude Fable 5 noreply@anthropic.com" line

git push --force

Once the amended commit lands, the bot re-scans and should pass. The PR itself looks good otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants